Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 7.4 compatibility #23

Merged
merged 2 commits into from
Dec 18, 2020
Merged

php 7.4 compatibility #23

merged 2 commits into from
Dec 18, 2020

Conversation

nutama
Copy link

@nutama nutama commented Nov 13, 2020

replaced deprecated usage of curly braces for string offset access
added travis build for php 7.4

@nutama nutama requested review from yannickl88 and mvannes November 13, 2020 16:10
@yannickl88
Copy link
Member

I think almost all of these cases are string access. Maybe replace them all with something like substr($string, $i, 1) or something?

@yannickl88
Copy link
Member

I think almost all of these cases are string access. Maybe replace them all with something like substr($string, $i, 1) or something?

hmm, nevermind. Not sure why, but I thought array access on a string was deprecated.

@nutama nutama marked this pull request as ready for review November 23, 2020 09:45
@nutama nutama merged commit b5c96fb into hostnet:1.1 Dec 18, 2020
@nutama nutama deleted the php7.4 branch December 18, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickprent rickprent rickprent approved these changes

@svandervlugt svandervlugt svandervlugt approved these changes

@yannickl88 yannickl88 Awaiting requested review from yannickl88

@mvannes mvannes Awaiting requested review from mvannes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nutama @yannickl88 @rickprent @svandervlugt