Feature/hgi 7305 - Flatten Customer Hierarchy Stream #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsyyid
requested changes
Feb 28, 2025
| th.Property( | ||
| "customerClient", | ||
| th.ObjectType( | ||
| th.Property("customer_id", th.StringType), |
There was a problem hiding this comment.
Can you fix the indentation here?
| @@ -87,15 +87,12 @@ def gaql(self): | |||
|
|
|||
| records_jsonpath = "$.results[*]" | |||
| name = "stream_customer_hierarchy" | |||
| primary_keys = ["customerClient__id"] | |||
| primary_keys = ["id"] | |||
There was a problem hiding this comment.
Should this be id or customer_id? They're almost the same thing right
There was a problem hiding this comment.
I'm keeping with how it was before where the unsanitized id is the pk, and the sanitized id (customer_id) is the partition key.
I'm pretty sure they are both unique, but I think it's generally safer to use the primary key that google gives us (Which is not sanitized)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.