Fix task IDs are not sorted on multiple tasks validation sidebar #4695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures that task IDs on the Validate Multiple Tasks page are sorted in ascending order for a better UX. This PR performs the sort on both the title and the
TaskValidationSelector
components, so that they are aligned.Resolves #4689
Implementation Details
Sorting is done on the task IDs array in
action.js
since that is the array that gets passed into all child components. I thought that placing the sort function there would make it more convenient in the future, so you don't need to worry about having to sort individual child components on their own anymore (the array is sorted, just display).(Sidenote) Javascript's
Array.prototype.sort
does a lexicographic sort by default (docs). Since thetasksIds
array is anumber[]
, I had to use a custom compare function.Type of change
How Has This Been Tested?
yarn start
in the./frontend
folderManage > Select a project > Contribute > Tasks > Validate (n) Tasks
(use a project with multiple pending validation tasks)yarn test
in the./frontend
folder. There were no unit tests for this file, so I tested my implementation on the UI.Here is a reference screenshot: