Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented code to display OMS information on settings page(#1ytrtk0) #37

Merged
merged 6 commits into from
Jan 17, 2022

Conversation

disha1202
Copy link
Contributor

Related Issues

Closes #

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

  • I read and followed contribution rules
  • I have changed the target to hacktoberfest branch

@@ -17,6 +17,13 @@
</ion-select>
</ion-item>

<!-- OMS information -->
<ion-item>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are indentation issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed indentation issues

<ion-item>
<ion-icon :icon="codeWorkingOutline" slot="start"/>
<ion-label>{{ $t("OMS") }}</ion-label>
<ion-note slot="end">{{instanceUrl}}</ion-note>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spacing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed spacing

@adityasharma7 adityasharma7 merged commit 76e40a8 into hotwax:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants