Implement streams Targeting Multiple Elements #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvdalen
commented
Aug 19, 2022
timvdalen
commented
Aug 19, 2022
|
@timvdalen Thanks! I really like the work you've done here. I'll take a stab at the things you left a comment. |
Merged
|
Hey @timvdalen I've made some tweaks here, and I also took the time to include the new |
Closed
|
Awesome, that was quick! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to Turbo Streams Targeting Multiple Elements, by adding the option to the response macros and all underlying Blade components.
https://turbo.hotwired.dev/reference/streams#targeting-multiple-elements
We realize that this is an impactful PR, and we don't expect it to be merged without change or further discussion.
Please view this PR as the start of a conversation around the topic.
We have tried to balance staying compatible with the syntax from the Turbo handbook (so no separate
<turbo-stream>component withtargets=support) with not making any breaking changes to the API of this package, but we have had to make a few hard choices along the way. In particular, it was not possible to not make any breaking changes to theStreamcomponent constructor without breaking compatibility with Turbo itself.