Keep flash in Turbo Frame requests #699
Merged
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A POST request can set the flash and return a redirect response. If a Turbo-Frame request that gets made before the redirect location gets called, the flash gets discared by the Turbo-Frame request. By making sure a Turbo-Frame request keeps the flash, we can avoid this problem.
seanpdoyle
reviewed
Nov 7, 2024
Comment on lines
+39
to
+51
| message = Message.create! | ||
|
|
||
| post messages_path | ||
| assert_equal @request.flash[:notice], 'Message was successfully created.' | ||
|
|
||
| get messages_path, headers: { "Turbo-Frame" => "true" } | ||
| assert_equal @request.flash[:notice], 'Message was successfully created.' | ||
|
|
||
| get messages_path | ||
| assert_equal @request.flash[:notice], 'Message was successfully created.' | ||
|
|
||
| get messages_path | ||
| assert_nil @request.flash[:notice] |
There was a problem hiding this comment.
Is it necessary to call Message.create!? Is the @request instance variable accessible as request?
Suggested change
| message = Message.create! | |
| post messages_path | |
| assert_equal @request.flash[:notice], 'Message was successfully created.' | |
| get messages_path, headers: { "Turbo-Frame" => "true" } | |
| assert_equal @request.flash[:notice], 'Message was successfully created.' | |
| get messages_path | |
| assert_equal @request.flash[:notice], 'Message was successfully created.' | |
| get messages_path | |
| assert_nil @request.flash[:notice] | |
| post messages_path | |
| assert_equal request.flash[:notice], "Message was successfully created." | |
| get messages_path, headers: { "Turbo-Frame" => "true" } | |
| assert_equal request.flash.notice, "Message was successfully created." | |
| get messages_path | |
| assert_equal request.flash.notice, "Message was successfully created." | |
| get messages_path | |
| assert_nil request.flash.notice |
There was a problem hiding this comment.
Hmm, the message was required in my initial change as I was following the redirect to message_url(id: 1).
In the current implementation it isn't required. I think this could use a little clean up.
|
@jorgemanrubia @brunoprietog are either of you able to enable CI to execute for this PR? |
|
Thanks @jorgemanrubia and @seanpdoyle ! |
|
Just wondering, but what if a turbo frame response renders the flash messages? Would this not then keep the messages and display them again (potentially) on another subsequent unrelated request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A POST request can set the flash and return a redirect response. If a Turbo-Frame request that gets made before the redirect location gets called, the flash gets discared by the Turbo-Frame request.
By making sure a Turbo-Frame request keeps the flash, we can avoid this problem.