Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CI matrix for Rails 8 #706

Closed
wants to merge 7 commits into from
Closed

update CI matrix for Rails 8 #706

wants to merge 7 commits into from
+8 −11

Conversation

adrienpoly
Copy link
Member

@adrienpoly adrienpoly commented Dec 23, 2024 •
edited
Loading

  • Removes EOL Ruby 2.7, 3.0
  • Removes EOL Rails 6.1, 7.0
  • Adds Rails 8
  • update sqlite dependency

@adrienpoly adrienpoly mentioned this pull request Dec 23, 2024
Open
seanpdoyle
seanpdoyle reviewed Dec 23, 2024
View reviewed changes
turbo-rails.gemspec
s.required_ruby_version = ">= 2.6.0"
s.required_ruby_version = ">= 3.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR.

There is a fair amount of overlap with #698, which also changes the Ruby version requirement.

As it relates to #681, I think there still needs to be a final release that deprecates support for 2.6 before main can drop support.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes thanks for pointing it out, I didn't see that PR. #698 looks more complete indeed. I think I ll close this one. the only addon is Rails 8 but that can easily be backported to #698

@adrienpoly
Copy link
Member Author

closing in favor of #698

@adrienpoly adrienpoly closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpdoyle seanpdoyle seanpdoyle left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrienpoly @seanpdoyle