Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: remove "test" docstring prefix #1052

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

seanpdoyle
Copy link
Contributor

The fact that each test case description starts with "test" is an artifact of the pre-Playwright test suite. Prior to Playwright, test cases were inferred from function names that started with "test".

Since Playwright doesn't impose those same expectations, the prefix can be omitted.

The fact that each test case description starts with `"test"` is an
artifact of the pre-Playwright test suite. Prior to Playwright, test
cases were inferred from function names that started with `"test"`.

Since Playwright doesn't impose those same expectations, the prefix can
be omitted.
@afcapel afcapel merged commit 0613595 into hotwired:main Oct 31, 2023
1 check passed
@afcapel
Copy link
Collaborator

afcapel commented Oct 31, 2023

Nice, thanks @seanpdoyle 🙏

@seanpdoyle seanpdoyle deleted the test-suite-docstrings branch October 31, 2023 14:00
afcapel added a commit that referenced this pull request Oct 31, 2023
* origin/main:
  Tests: remove `"test"` docstring prefix (#1052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants