Don't double-paginate GitHub responses #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ).with( | ||
| headers: { "Authorization" => "token #{token}" } | ||
| ).to_return( | ||
| status: 200, | ||
| body: File.read('spec/support/fixtures/github_repos_response_for_jimtom.json'), | ||
| headers: { 'Content-Type' => 'application/json; charset=utf-8' } | ||
| headers: { | ||
| "Link" => %(<https://api.github.com/user/repos?page=2&per_page=100>; rel="next"), |
|
👍 |
Oktokit::Client is always initialized with `auto_paginate: true`, so no additional pagination work is necessary. In fact, paginating from Hound caused lists with > 100 results to return duplicate entries and perform redundant work.
bernerdschaefer
force-pushed
the
bs-fix-pagination
branch
from
cf93eee to
23cbbe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oktokit::Client is always initialized with
auto_paginate: true,so no additional pagination work is necessary. In fact, paginating
from Hound caused lists with > 100 results to return duplicate
entries and perform redundant work.