-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Flatpak and perhaps Snap? #699
Comments
There's an issue opened for Snap support: #525. I could not get it working due to some Electron errors. I am using |
So I published in SnapStore, I guess. I don't really agree with all that snap things so I am not a user and can't test :) |
Yay, seems like they have merged support to build flatpaks, will have to check that electron-userland/electron-builder#5711 |
I've started working on this in PR #1013, but seeing as a few decisions should be hashed out here according to the CONTRIBUTING.md, it's just a proof-of-concept at the moment. Flatpak support will require a
I think that covers most of the major design decisions. My proof-of-concept seems to be working quite well except for the app indicator which is usable but only displays a |
Hi @jwillikers , I am holidaying a lot these days, but did you use electron-userland/electron-builder#5711 or something else? Not sure how it works, but I was planning to use that. I am building Stretchly builds using electron-builder on CI so keep doing that would be best |
@hovancik Sorry, I thought you we're linking to the official Flatpak documentation which added a section on Electron, but the support in electron-builder looks great! I'll see what I can do to make that happen. It doesn't really solve the problem of publishing to Flathub, though. If you want to publish to Flathub, they actually take care of all the CI and build your app from sources using a Flatpak manifest you submit to them. Your app even gets a dedicated repository under their organization for this. GNOME Podcasts Flathub repo is a simple example. Anyways, enjoy your holidays and there's of course no rush to get back to me! |
I guess it might be similar to Snap? I had to register on snap web and add my project there. Then I am building package on CI and manually publish/push to their server via docker container that has all the needed stuff. https://github.com/hovancik/stretchly/blob/trunk/publish-snap.md |
It's a little bit different from Snap in that Flathub's CI infrastructure will build your Flatpak for you. It's not actually necessary for you to build anything locally and they don't allow you to submit binaries. Flathub uses what Flatpak calls a manifest file, which describes how to build and package your app in a declarative syntax. They then build your application and package it up from those instructions on their nodes. They act like a bit of a trusted source since you know the binaries weren't tampered with since they built them. The manifest Flathub uses to build your app will get it's own GitHub repository under their organization after you submit a pull-request to flathub/flathub for your app. You'll be given write permissions to the repository and will need to update it accordingly when you release new versions of Stretchly. |
Any updates on Flatpak support? |
@12people Well, there's still a concerning bug where the background color is always bright white instead of the selected color. I haven't updated the Flatpak branch in a while, so I'll need to update that. The main thing that I need to do is convert my current Flatpak manifest to the Electron Builder configuration, which should be pretty straight-forward. We can address Flathub publication after that is finished. I haven't gotten around to this, but I also wasn't aware there was still so much interest. I'll likely have time to move this forward this weekend, but if I'm busy due to the holidays I should get to it the following weekend. |
I've started new job in September and was superbusy so no progress on Stretchly since then. I've made new release to publish older changes and now I am pretty much starting to look at all of the issues since few months ago :( |
I've managed to at least update everything to the latest version in my Flatpak branch and ensure I can still built the Flatpak using I've started getting things to build with Electron-Builder. It seems to crash pretty quickly once it reaches the step where it runs |
Oh, that's fantastic. I just realized that the updated Flatpak built directly with |
Would be good if some flatpak user could try. Seems like electron-builder is not working well with it: electron-userland/electron-builder#6211 |
@12people @sjoerdschouten Stretchly is now live on Flathub! https://flathub.org/apps/details/net.hovancik.Stretchly |
Many thanks @jwillikers ! :) |
Hi there,
Would it be possible to ship Stretchly as a Flatpak (or potentially a Snap package)?
The tool would become available for almost any distribution and it would greatly simplify maintaining it since updates are received automatically.
Looking forward hearing from you.
The text was updated successfully, but these errors were encountered: