-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian translations #603
Add Russian translations #603
Conversation
As a suggestion for string keys like |
thanks @illright the format there is a standard from the libary and is looks different for different languages. Ie English has You can put your language code here and see ranges: https://jsfiddle.net/sm9wgLze I'll add this to original issue so other can see it as well. |
@illright Would it be possible for you to run Stretchly locally and see where the translations are or should I keep addings screenshots to your comments? The best for testing should be if you could run it yourself locally |
Yeah, I suppose I can run it locally |
👍 If you go to main.js, and change the line If you need help, I am on gitter https://gitter.im/stretchly/Lobby |
And it would be really nice to be able to translate break ideas as well |
@illright thanks ;]
Let me know if I can merge or you wanna make some change :) |
So with this last commit I've translated "percent" as "percent of duration of the break". This should make enough sense, but then I'd recommend making the same adjustment for other languages, because, as I said, it didn't make sense to me even in English up until you explained it. Other than that, yep, good to merge |
Codecov Report
@@ Coverage Diff @@
## redesign #603 +/- ##
============================================
+ Coverage 52.14% 52.26% +0.11%
============================================
Files 16 16
Lines 861 861
============================================
+ Hits 449 450 +1
+ Misses 412 411 -1
Continue to review full report at Codecov.
|
Issue: #584
Requirements
node
version specified inpackage.json
was used (ie using nvm).npm install --no-save
).npm run lint
reports no offenses.npm run test
is error-free.Description of the Change
Added Russian translations. In some places there are pseudo-comments, hoping you could shed some light on the context of some strings to be able to translate them more accurately.