Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian translations #603

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Add Russian translations #603

merged 4 commits into from
Jun 3, 2020

Conversation

illright
Copy link
Contributor

Issue: #584

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation.
  • during development, node version specified in package.json was used (ie using nvm).
  • package versions and package-lock.json were not changed (npm install --no-save).
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.

Description of the Change

Added Russian translations. In some places there are pseudo-comments, hoping you could shed some light on the context of some strings to be able to translate them more accurately.

@illright illright marked this pull request as draft May 31, 2020 08:40
@illright
Copy link
Contributor Author

As a suggestion for string keys like seconds_0, maybe it'd be helpful to clarify the range of numbers that they cover, something like seconds_[5; +inf) (though this might seem clumsy and non-conformant to the identifier regex)

@hovancik
Copy link
Owner

hovancik commented Jun 1, 2020

thanks @illright

the format there is a standard from the libary and is looks different for different languages. Ie English has name and name_plural, Chinese has no plural, etc.

You can put your language code here and see ranges: https://jsfiddle.net/sm9wgLze

I'll add this to original issue so other can see it as well.

@hovancik
Copy link
Owner

hovancik commented Jun 1, 2020

@illright Would it be possible for you to run Stretchly locally and see where the translations are or should I keep addings screenshots to your comments?

The best for testing should be if you could run it yourself locally

@illright
Copy link
Contributor Author

illright commented Jun 1, 2020

Yeah, I suppose I can run it locally

@hovancik
Copy link
Owner

hovancik commented Jun 1, 2020

👍

If you go to main.js, and change the line isContributor: false to isContributor: true, on next start of the app you will be able to Click on button "Contributor Preferences" in "Love Stretchly" page and open extra settings.

If you need help, I am on gitter https://gitter.im/stretchly/Lobby

@illright
Copy link
Contributor Author

illright commented Jun 2, 2020

When I clicked "Sign in with GitHub" in the "Love Stretchly" screen, I got this screen, the strings for which I have not seen in the locale file. Also it has a typo in the word "feeling" :p
image

@illright
Copy link
Contributor Author

illright commented Jun 2, 2020

Also this is confusing to me both in English and in Russian:
image
I'd expect the units of "postponable for" to be time, not percents. Perhaps this label could be rephrased

@illright
Copy link
Contributor Author

illright commented Jun 2, 2020

image
This space before the full stop is also unfortunate

@illright
Copy link
Contributor Author

illright commented Jun 2, 2020

And it would be really nice to be able to translate break ideas as well

@illright illright marked this pull request as ready for review June 2, 2020 10:05
@hovancik
Copy link
Owner

hovancik commented Jun 3, 2020

@illright thanks ;]

  1. the non-translatable login is auth webserver, there are no translations, I've fixed the typo ;]
  2. postponable for is percentage of break in which you can postpone. Postpone for is how long it will be postponed. Feel free to use text that you think will make sense, ie in first explanation paragraph.
  3. interesting, not sure why there is white space before full stop, should not be. Will have to look into it. There's basically span, a, span so should not be any space
  4. Hopefully breaks will be translatable soon, I am applying for RGSoC where students should work on it.

Let me know if I can merge or you wanna make some change :)

@illright
Copy link
Contributor Author

illright commented Jun 3, 2020

So with this last commit I've translated "percent" as "percent of duration of the break". This should make enough sense, but then I'd recommend making the same adjustment for other languages, because, as I said, it didn't make sense to me even in English up until you explained it.

Other than that, yep, good to merge

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #603 into redesign will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           redesign     #603      +/-   ##
============================================
+ Coverage     52.14%   52.26%   +0.11%     
============================================
  Files            16       16              
  Lines           861      861              
============================================
+ Hits            449      450       +1     
+ Misses          412      411       -1     
Impacted Files Coverage Δ
app/utils/untilMorning.js 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e6f2c...9ec5fd2. Read the comment docs.

@hovancik hovancik merged commit 17629e5 into hovancik:redesign Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants