-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm/release-chart): update version for umbrella chart children #329
base: main
Are you sure you want to change the base?
Conversation
@fredleger it is complicated to upgrade the umbrella chart children versions. Because if we change the version of a child, we must change the root Chart dependencies version so we must run helm dependency update (https://github.com/hoverkraft-tech/ci-github-container/actions/runs/10176351460/job/28145583710?pr=329#step:4:291) It's not good to me because we don't have control on what we update. What's your opinion? |
That's true I didn't anticipate this point. My bad. About the control I'm not sure, if this is a real dependency like mysql the version is locked by the semver used. If it's one of our child deps then we know what we are updating. Maybe I'm missing something in the picture here. Let me know. Another way maybe to find a way to do only partial updates of lock file but I'm not sure it's even possible. |
|
786e002
to
38115ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think limiting it to dependencies starting with file protocol is clever and give good control over it
How can we do it? |
@fredleger should check it |
5b17097
to
2ae6e0e
Compare
@neilime i will try to work on it soon |
1603e42
to
1dc2b52
Compare
4d9a1ac
to
35d3b2a
Compare
Signed-off-by: Emilien Escalle <[email protected]>
35d3b2a
to
89835ce
Compare
Nous sommes un peu bloqués sur ce point. On pourrait tenter de faire remonter le point upstream dans helm en expliquant notre besoin initial ? |
No description provided.