Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --address-count options. Generate multiple addresses for the same wallet #207

Merged
merged 16 commits into from
Jul 29, 2020
Merged

Add --address-count options. Generate multiple addresses for the same wallet #207

merged 16 commits into from
Jul 29, 2020

Conversation

isvforall
Copy link
Contributor

No description provided.

howardwu
howardwu requested changes Jun 23, 2020
View reviewed changes
Copy link
Owner

@howardwu howardwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a few changes needed to have this working correctly. After addressing the requested changes, could you include an update to the README commands to reflect this new functionality?

wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
wagyu/cli/parameters/option.rs Outdated Show resolved Hide resolved
@isvforall isvforall requested a review from howardwu June 24, 2020 23:01
@isvforall isvforall marked this pull request as draft June 24, 2020 23:03
@isvforall isvforall marked this pull request as ready for review June 25, 2020 00:45
howardwu
howardwu requested changes Jun 25, 2020
View reviewed changes
Copy link
Owner

@howardwu howardwu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two CLI command cases that should be addressed - hd and import-hd - before this can be merged.

In the case of creating a new HD wallet, the user should be able to specify --index or --indices to print out a specific index or range of wallets with that newly generated HD wallet.

In the case of importing an HD wallet, the user should also be able to specify --index or --indices to print out a specific index or range of wallets with that imported HD wallet.

wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
howardwu
howardwu reviewed Jun 29, 2020
View reviewed changes
wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
howardwu
howardwu requested changes Jul 5, 2020
View reviewed changes
wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
wagyu/cli/ethereum.rs Outdated Show resolved Hide resolved
@howardwu
Copy link
Owner

howardwu commented Jul 5, 2020

I have updated the implementation. Pending confirmation on the source of your derivation paths, this PR is ready for merge

@howardwu
Copy link
Owner

howardwu commented Jul 5, 2020

#167

@howardwu howardwu mentioned this pull request Jul 5, 2020
Open
@howardwu
Copy link
Owner

howardwu commented Jul 5, 2020

LGTM, thanks for the PR

@howardwu howardwu added the enhancement New feature or request label Jul 6, 2020
@howardwu howardwu merged commit 217c139 into howardwu:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardwu howardwu howardwu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isvforall @howardwu