This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
remove Bats submodule and work around Bats bug #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-ogas
reviewed
Sep 26, 2019
| @@ -72,12 +71,12 @@ jobs: | |||
| env: CH_BUILDER=buildah TARBALL=export INSTALL=yes | |||
| - <<: *stage_install | |||
| env: CH_BUILDER=buildah-runc TARBALL=export INSTALL=yes | |||
| - <<: *stage_install | |||
| env: CH_BUILDER=buildah-setuid TARBALL=export INSTALL=yes | |||
There was a problem hiding this comment.
Is this related to removing the bats submodule? If not, perhaps we should make a separate issue, which we can also close with this PR. Thoughts?
There was a problem hiding this comment.
Probably? I removed the TARBALL=export-bats one, which freed up a space in the stage, so I added this one.
j-ogas
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #552 and #553.