Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33278 Fix //version race condition in parquetType.ecl #19440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HPCC-33278 Fix //version race condition in parquetType.ecl #19440

wants to merge 1 commit into from

Conversation

jackdelv
Copy link
Contributor

@jackdelv jackdelv commented Jan 21, 2025 •
edited
Loading

  • Add workunit id to filename to avoid multiple threads reading/writing to the same file
  • Clean up temporary files
  • Explicitly order actions to allow files to be deleted last

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jackdelv jackdelv requested a review from AttilaVamos January 21, 2025 19:19
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33278

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

AttilaVamos
AttilaVamos reviewed Jan 22, 2025
View reviewed changes
testing/regress/ecl/parquetTypes.ecl
OUTPUT(qStringResult, NAMED('QStringTest'), OVERWRITE),
OUTPUT(utf8Result, NAMED('UTF8Test'), OVERWRITE),
OUTPUT(unicodeResult, NAMED('UnicodeTest'), OVERWRITE)
SEQUENTIAL(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you reorganise the write file then read it back parallel for each type from previous version to this parallel write and sequential read? Is the ParquetIO.Read() not thread safe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was because I was seeing some weird behavior with the SEQUENTIAL call. Before I explicitly ordered the Parquet.Write actions to come before the OUTPUTs, the DeleteExternalFile actions would occur first despite coming after the OUTPUTs in the list of SEQUENTIAL arguments. This meant the cleanup of the files happened before they were written and read from leaving behind every file that was used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Read is thread safe, but the reason for the sequential read is because the result order needs to be the same to match the key file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see. Fair enough.

This Morning I found 2 more errors related to parquetType test:

557. parquetTypes(compressionType='GZip') 	Error: 0: parquet: IOError: Couldn't deserialize thrift: TProtocolException: Invalid data
558. parquetTypes(compressionType='Brotli')	Error: 0: parquet: IOError: Couldn't deserialize thrift: TProtocolException: Invalid data

What do you think about are those errors related to versions race condition as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so. I think that would be the result of reading from a file while something is in the middle of writing a record batch to it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@jackdelv jackdelv requested a review from AttilaVamos January 29, 2025 16:53
AttilaVamos
AttilaVamos approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@AttilaVamos AttilaVamos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to merge.

testing/regress/ecl/parquetTypes.ecl
import ^ as root;
compressionType := #IFDEFINED(root.compressionType, 'UNCOMPRESSED');

IMPORT Std;
IMPORT Parquet;

dropzoneDirectory := Std.File.GetDefaultDropZone();
dropzoneDirectory := Std.File.GetDefaultDropZone() + '/regress/parquet/' + WORKUNIT + '-';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just pondering about is this name (dropzoneDirectory) still correct or not, because now it contains not only the default DZ path but a file path and prefix as well. I feel it is a bit misleading, but hopefully not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AttilaVamos AttilaVamos AttilaVamos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdelv @AttilaVamos