Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slurm credit cost updates #445

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Slurm credit cost updates #445

merged 4 commits into from
Dec 19, 2024

Conversation

MaximeVdB
Copy link
Contributor

Various refinements + adding wICE extension numbers + mentioning sam-quote.

@MaximeVdB MaximeVdB self-assigned this Dec 6, 2024
mselwa
mselwa approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mselwa mselwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything look ok. I just find it strange to use account=lp_astrophysics_014 in the example. We used to have lp_myproject/lp_hpcinfo.

mselwa
mselwa approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@mselwa mselwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about account=lp_astrophysics_014 as in the other one

@MaximeVdB
Update and correct the job credit cost example
77beabd 
Updating in the sense that it's better to not explicitly mention Skylake
since the default partition now only consists of Cascadelake nodes.

Correcting in the sense that this also involves a floor function.
And to use more generic-looking credit account and jobscript names.
@MaximeVdB
Mention sam-quote tool for credit cost estimates
9536595
@MaximeVdB MaximeVdB force-pushed the update_credit_charge_rates branch from 8eaa900 to 9536595 Compare December 19, 2024 14:01
@MaximeVdB
Copy link
Contributor Author

Everything look ok. I just find it strange to use account=lp_astrophysics_014 in the example. We used to have lp_myproject/lp_hpcinfo.

I just went with the given example but its indeed better to use a more generic name (same for the name of the jobscript). I've now reworked my commits accordingly.

@MaximeVdB MaximeVdB merged commit d5868fa into hpcleuven:master Dec 19, 2024
1 check passed
@MaximeVdB MaximeVdB deleted the update_credit_charge_rates branch December 19, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mselwa mselwa mselwa approved these changes

@WouterVanAssche WouterVanAssche WouterVanAssche approved these changes

Assignees

@MaximeVdB MaximeVdB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximeVdB @mselwa @WouterVanAssche