CON-1395: Avoid FailedPreStopHook warning on hpe-csi-node termination #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgcostea
reviewed
Nov 3, 2020
Comment on lines
-39
to
-42
| lifecycle: | ||
| preStop: | ||
| exec: | ||
| command: ["/bin/sh", "-c", "rm -rf /registration/csi.hpe.com /registration/csi.hpe.com-reg.sock"] |
There was a problem hiding this comment.
What is the downside of not removing this socket?
There was a problem hiding this comment.
It is a zero-byte file, but the inode won't be reclaimed when the HPE CSI driver isn't used.
There was a problem hiding this comment.
Should we update the node-driver-registrar image?
kubernetes-csi/node-driver-registrar#61
It seems we are quite dated on ours.
There was a problem hiding this comment.
Indeed, the latest image does the cleanup automatically.
The csi-node-driver-registrar container in the hpe-csi-node daemonset defines a pre-stop hook that runs a command in the container. However, the container does not include a shell command, so the hook execution fails with this error: "exec: \"/bin/sh\": stat /bin/sh: no such file or directory". Avoid the error by removing the hook. Signed-off-by: Roger Kumpf <[email protected]>
Signed-off-by: Roger Kumpf <[email protected]>
Signed-off-by: Roger Kumpf <[email protected]>
rgcostea
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The csi-node-driver-registrar container in the hpe-csi-node daemonset defines
a pre-stop hook that runs a command in the container. However, the container
does not include a shell command, so the hook execution fails with this error:
"exec: "/bin/sh": stat /bin/sh: no such file or directory". Avoid the error
by removing the hook.