Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 15 on supporting config feature #16

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

Qiwen-Yu
Copy link
Contributor

No description provided.

@hphan9
Copy link
Owner

hphan9 commented Oct 12, 2021

Thank you @Qiwen-Yu , I will review .

@hphan9
Copy link
Owner

hphan9 commented Oct 14, 2021

Hi @Qiwen-Yu ,
Thank you for your work.
I checked the file, and several problems made the program could not run. Please check:

  • It should be using Newtonsoft.Json.Linq;
  • The KeyValuePair<string, JToken> is not right, you can use jObj["input"] to get the value
  • missing; in line 66
  • you forget to initialize the inputname variable.
    Would you please fix the program.cs file according to these problems.
    Thank you very much,

@humphd
Copy link

humphd commented Oct 14, 2021

@Qiwen-Yu Are you planning to make these changes soon?

@Qiwen-Yu
Copy link
Contributor Author

Hi, I have submitted a new commit to fix issue #15

e1ac107

@hphan9
Copy link
Owner

hphan9 commented Oct 15, 2021

It looks great, thank you

@hphan9 hphan9 merged commit 761020c into hphan9:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants