Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bc 7165 include tldraw to the quick links #3235

Merged
merged 14 commits into from
May 8, 2024

Conversation

VikDavydiuk
Copy link
Contributor

@VikDavydiuk VikDavydiuk commented May 6, 2024

Short Description

Change tested on env :
https://bc-7165-include-tldraw-to-the-quick-links.brb.dbildungscloud.dev/
Tested only copy function. No issues found, acceptances criteria done but 3 points that need clarification:

  • group is not in topic is in course - should be as a separate element
  • column board and list board - we do not differentiate between these elements
  • in figma we have a text editor - no copy logic implementation for this element yet
    see ticket: https://ticketsystem.dbildungscloud.de/browse/BC-7165

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@VikDavydiuk VikDavydiuk added the WIP someone is working on that label May 6, 2024
@VikDavydiuk VikDavydiuk self-assigned this May 6, 2024
@VikDavydiuk VikDavydiuk removed the WIP someone is working on that label May 8, 2024
blazejpass
blazejpass previously approved these changes May 8, 2024
Copy link

sonarqubecloud bot commented May 8, 2024

@VikDavydiuk VikDavydiuk merged commit 52ee72a into main May 8, 2024
47 of 49 checks passed
@VikDavydiuk VikDavydiuk deleted the BC-7165-Include-tldraw-to-the-quick-links branch May 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants