Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-8168 - Implementing video conferences in FE and remaining issues #3480

Merged
merged 57 commits into from
Jan 17, 2025
Merged

BC-8168 - Implementing video conferences in FE and remaining issues #3480

merged 57 commits into from
Jan 17, 2025

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Dec 18, 2024 •
edited
Loading

Short Description

Links to Ticket and related Pull-Requests

BC-8168

hpi-schul-cloud/schulcloud-server#5420

hpi-schul-cloud/dof_app_deploy#1086

Changes

see ticket for detailed listing

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MartinSchuhmacher MartinSchuhmacher self-assigned this Dec 18, 2024
MartinSchuhmacher and others added 21 commits December 18, 2024 12:02
@MartinSchuhmacher
Merge branch 'main' into BC-8168-bbb-finalize
55eabdb
@MartinSchuhmacher
pushing current test WIP for configuration dialog component
cdec9b7
@odalys-dataport
use outlined video icon
1d5e6d3
@odalys-dataport
Merge branch 'BC-8168-bbb-finalize' of https://github.com/hpi-schul-c…
4fca722 
…loud/nuxt-client into BC-8168-bbb-finalize
@odalys-dataport
adjust pulse animation & pulsate 5 times
e4064d8
@MartinSchuhmacher
fixing and adding tests for VideoConferenceConfigurationDialog
ac2a7f7
@MartinSchuhmacher
Merge branch 'main' into BC-8168-bbb-finalize
7d33c53
@MartinSchuhmacher
adding note for deep watcher in configuration dialog
d6b50b9
@MartinSchuhmacher
adding type safety for boardapi composable
859ffe3
@MartinSchuhmacher
Merge branch 'main' into BC-8168-bbb-finalize
80bf049
Fix wording in dialog and show status right aligned
0b3625f
@f-g-s
remove comment
c910de4
@MartinSchuhmacher
moving VC configuration dialog to ui folder
ba56f0b
@MartinSchuhmacher
adjusting Room VC section to script setup and use configuration dialo…
1b8a563 
…g component
@odalys-dataport
Merge branch 'main' of https://github.com/hpi-schul-cloud/nuxt-client …
506345d 
…into BC-8168-bbb-finalize
@odalys-dataport
fix pulsating dot always being there
ae12605
@odalys-dataport
setting link prop on bbb card should fix hover discrepancy
297d1b6
@odalys-dataport
use contentelementbar in bbb-element-create
c3c7d6a
@odalys-dataport
add missing imports
e5f879d
@odalys-dataport
remove ContentElementBar again from bbb-create
0d49bcd
@f-g-s
add responsive layout to videoconf create
b456d41
uidp
uidp reviewed Jan 7, 2025
View reviewed changes
...es/feature/board-video-conference-element/components/VideoConferenceContentElementCreate.vue Outdated
const isListLayout = ref(injectStrict(BOARD_IS_LIST_LAYOUT));
const { smAndUp } = useDisplay();

const hasRowStyle = computed(() => {
Copy link
Contributor

@uidp uidp Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasListStyle or isRenderedAsList?

@MartinSchuhmacher MartinSchuhmacher mentioned this pull request Jan 13, 2025
Merged
3 tasks
uidp
uidp previously approved these changes Jan 16, 2025
View reviewed changes
@MartinSchuhmacher MartinSchuhmacher mentioned this pull request Jan 16, 2025
Merged
1 task
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MartinSchuhmacher MartinSchuhmacher merged commit 0c3ced2 into main Jan 17, 2025
70 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-8168-bbb-finalize branch January 17, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uidp uidp uidp approved these changes

@odalys-dataport odalys-dataport Awaiting requested review from odalys-dataport

Assignees

@MartinSchuhmacher MartinSchuhmacher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinSchuhmacher @uidp @odalys-dataport @f-g-s @virgilchiriac