Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1990 Add preferred name option to migration wizard #3485

Merged
merged 10 commits into from
Jan 13, 2025
Merged

N21-1990 Add preferred name option to migration wizard #3485

merged 10 commits into from
Jan 13, 2025

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jan 2, 2025 •
edited
Loading

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Jan 2, 2025
Merged
3 tasks
mrikallab
mrikallab previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@mrikallab mrikallab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You refactored the whole api.ts, please check

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit e02c986 into main Jan 13, 2025
70 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1990-preferred-name branch January 13, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBergCap MBergCap MBergCap approved these changes

@mrikallab mrikallab mrikallab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarvinOehlerkingCap @mrikallab @MBergCap