Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-8584 - refactor board menu #3493

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Jan 10, 2025

Short Description

refactoring of board-menu-components

Links to Ticket and related Pull-Requests

BC-8584
hpi-schul-cloud/e2e-system-tests#279

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

NFriedo
NFriedo previously approved these changes Jan 13, 2025
Copy link
Contributor

@NFriedo NFriedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some keyboard bugs that must be adressed before merging:

  • External Tool Element: not possible to focus whole element in view and edit mode to open or move element
  • Etherpad: not possible to focus element

Renaming of board-menu-actions to be kebab-menu-actions.
NFriedo
NFriedo previously approved these changes Jan 14, 2025
NFriedo
NFriedo previously approved these changes Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants