-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-8584 - refactor board menu #3493
Open
hoeppner-dataport
wants to merge
26
commits into
main
Choose a base branch
from
BC-8584-refactor-board-menu
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFriedo
reviewed
Jan 13, 2025
…into BC-8584-refactor-board-menu
NFriedo
reviewed
Jan 13, 2025
NFriedo
previously approved these changes
Jan 13, 2025
NFriedo
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some keyboard bugs that must be adressed before merging:
- External Tool Element: not possible to focus whole element in view and edit mode to open or move element
- Etherpad: not possible to focus element
Renaming of board-menu-actions to be kebab-menu-actions.
NFriedo
previously approved these changes
Jan 14, 2025
1 task
NFriedo
previously approved these changes
Jan 14, 2025
…into BC-8584-refactor-board-menu
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
refactoring of board-menu-components
Links to Ticket and related Pull-Requests
BC-8584
hpi-schul-cloud/e2e-system-tests#279
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging