-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use platform aware class in tests #619
Use platform aware class in tests #619
Conversation
Thanks for the PR, Max. I had already adjusted the tests via 3f277b9, but cherry-pick the relevant bits from this PR via e03bd96. Nonetheless, the Pharo 12 builds still fail:
https://github.com/hpi-swa/smalltalkCI/actions/runs/7159267912/job/19492329016?pr=619#step:4:996 |
That's because those images are not the |
I'm not sure I understand. Is Pharo 12 considered stable or not? Nonetheless, the tests are failing in a weird way in that image. Are you sure the code you recently added to find classes in categories is doing what it should be? |
No, Pharo 12 isn't stable yet. Alpha and 12 are the same thing, but there is already a Yes, the code should be fine. It works for the alpha build. |
Fixes #618