Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use platform aware class in tests #619

Closed

Conversation

theseion
Copy link
Collaborator

Fixes #618

@theseion theseion requested a review from fniephaus December 10, 2023 17:21
@fniephaus
Copy link
Member

Thanks for the PR, Max. I had already adjusted the tests via 3f277b9, but cherry-pick the relevant bits from this PR via e03bd96.

Nonetheless, the Pharo 12 builds still fail:

#########################
# 9 tests did not pass: #
#########################

SCIPharoMonticelloLoadSpecTest
 ✗ #testAddLoadedClassesFrom (4ms)
TestFailure: Denial failed
SCIPharoMonticelloLoadSpecTest(TestAsserter)>>assert:description:resumable:
SCIPharoMonticelloLoadSpecTest(TestAsserter)>>deny:description:resumable:
SCIPharoMonticelloLoadSpecTest(TestAsserter)>>deny:description:
SCIPharoMonticelloLoadSpecTest(TestAsserter)>>deny:
SCIPharoMonticelloLoadSpecTest>>testAddLoadedClassesFrom ...deny: (self spec loadedClasses isEmpty)
SCIPharoMonticelloLoadSpecTest(TestCase)>>performTest

SmalltalkCISpecTest
 ✗ #testClassesToTest (9ms)
TestFailure: Assertion failed
SmalltalkCISpecTest(TestAsserter)>>assert:description:resumable:
SmalltalkCISpecTest(TestAsserter)>>assert:description:
SmalltalkCISpecTest(Object)>>assert:
SmalltalkCISpecTest>>testClassesToTest ...assert: (classes includes: SmalltalkCITest)
SmalltalkCISpecTest(TestCase)>>performTest

SmalltalkCITest
 ✗ #testClassesForCategories (6ms)
TestFailure: Assertion failed
SmalltalkCITest(TestAsserter)>>assert:description:resumable:
SmalltalkCITest(TestAsserter)>>assert:description:
SmalltalkCITest(Object)>>assert:
SmalltalkCITest>>testClassesForCategories ...assert: (classes includes: SmalltalkCI)
SmalltalkCITest(TestCase)>>performTest
 ✗ #testClassesFrom (6ms)
TestFailure: Assertion failed
SmalltalkCITest(TestAsserter)>>assert:description:resumable:
SmalltalkCITest(TestAsserter)>>assert:description:
SmalltalkCITest(Object)>>assert:
SmalltalkCITest>>testClassesFrom ...assert: (classes includes: SmalltalkCI)
SmalltalkCITest(TestCase)>>performTest
 ✗ #testClassesInCategory (0ms)
TestFailure: Assertion failed
SmalltalkCITest(TestAsserter)>>assert:description:resumable:
SmalltalkCITest(TestAsserter)>>assert:description:
SmalltalkCITest(Object)>>assert:
SmalltalkCITest>>testClassesInCategory ...assert: (classes includes: SmalltalkCI)
SmalltalkCITest(TestCase)>>performTest
 ✗ #testClassesWithCategoryNames (2ms)
TestFailure: Assertion failed
SmalltalkCITest(TestAsserter)>>assert:description:resumable:
SmalltalkCITest(TestAsserter)>>assert:description:
SmalltalkCITest(Object)>>assert:
SmalltalkCITest>>testClassesWithCategoryNames ...assert: (classes includes: SmalltalkCI)
SmalltalkCITest(TestCase)>>performTest

SCITestReporterXMLTest
 ✗ #testReportSuccess (22ms)
TestFailure: Assertion failed
SCITestReporterXMLTest(TestAsserter)>>assert:description:resumable:
SCITestReporterXMLTest(TestAsserter)>>assert:description:
SCITestReporterXMLTest(Object)>>assert:
SCITestReporterXMLTest>>testReportSuccess ...assert: index > 0
SCITestReporterXMLTest(TestCase)>>performTest

SCITestRunnerTest
 ✗ #testRunClasses (11ms)
TestFailure: Assertion failed
SCITestRunnerTest(TestAsserter)>>assert:description:resumable:
SCITestRunnerTest(TestAsserter)>>assert:description:
SCITestRunnerTest(Object)>>assert:
SCITestRunnerTest>>testRunClasses ...assert: runner isSuccessful
SCITestRunnerTest(TestCase)>>performTest
 ✗ #testRunSpecNamed (12ms)
TestFailure: Assertion failed
SCITestRunnerTest(TestAsserter)>>assert:description:resumable:
SCITestRunnerTest(TestAsserter)>>assert:description:
SCITestRunnerTest(Object)>>assert:
SCITestRunnerTest>>testRunSpecNamed ...assert: runner isSuccessful
SCITestRunnerTest(TestCase)>>performTest

https://github.com/hpi-swa/smalltalkCI/actions/runs/7159267912/job/19492329016?pr=619#step:4:996

@fniephaus fniephaus closed this Dec 10, 2023
@theseion theseion deleted the make-tests-use-platform-aware-class branch December 10, 2023 20:45
@theseion
Copy link
Collaborator Author

That's because those images are not the alpha images. The URL for the Pharo 12 images ends in 120. We should probably remove Pharo64-12 from the list of images, or at least from the test matrix. That image hasn't been updated in a while.

@fniephaus
Copy link
Member

We should probably remove Pharo64-12 from the list of images, or at least from the test matrix.

I'm not sure I understand. Is Pharo 12 considered stable or not? Nonetheless, the tests are failing in a weird way in that image. Are you sure the code you recently added to find classes in categories is doing what it should be?

@theseion
Copy link
Collaborator Author

No, Pharo 12 isn't stable yet. Alpha and 12 are the same thing, but there is already a 120 image, which isn't updated by the nightly build. That means that Pharo64-12 is not the same thing as Pharo64-alpha.

Yes, the code should be fine. It works for the alpha build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PackageOrganizer>>#listAtCategoryNamed: deprecated in Pharo 12
2 participants