fix(reporting): replace scenario_info.id_hash with uuid for an edge case bug on expand / collapse #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
There's an edge case where the html report scenarios'
data-id-hash
isnt created uniquely. I couldn't create a minimum reproducible example but it does happen on our project.This is related to mutating the scenario names on runtime which we have done a fix for just recently.
One of the side effects of this is that when I expand / collapse one scenario, everything expands and collapses too.
Proposed Fix
Instead of creating a hash based on the scenario name and line, I replaced it with a uuid instead. I'm guessing that hash is supposed to be unique anyway.
PS
hacktoberfest-accepted
label please. Thank you!