feat: cmp async #1583

folke · 2023-05-21T15:56:20Z

Made part of cmp async.

async.new: starts a new coroutine that will resume at most 1ms per vim.loop tick. Returns an Async
async.yield: when called from inside a coroutine, this will yield. Does nothing when not in an async context
async.wrap: wraps a function that async.new for every invocation
Async:await: you can either pass a callback that gets executed when the async finishes, or nil, to synchonously wait and get the result
Async:cancel: cancels the running function on next yield
source.get_entries: added async.yield in the main loop. This method can still be called from outside an async function, but then it will of course not automatically re-schedule on the loop when taking too long
Added some additional checks in source.complete to make sure the context is still the same as the one we're completing
updated async.throttle to properly deal with async functions in terms of running and cancelling

This PR removes all stuttering from taildwind (biggest offender).

folke · 2023-05-21T16:45:43Z

Just fixed the tests. Ready for testing by anyone that feels up for it :)

folke · 2023-05-21T20:28:45Z

@yioneko would be great if you could also review this

yioneko · 2023-05-22T03:08:21Z

Nice work! I believe this will completely remove any user-blocking experience.

lua/cmp/utils/async.lua

lua/cmp/source.lua

yioneko

I've tested locally and this works fine for me.

folke · 2023-05-22T06:57:07Z

I removed pre-filtering from source.get_entries and added a new config option view.max_items.

The resulting items in the entries view are now always correct according to the scoring.

See d1136e5

…async.abort`

folke · 2023-05-22T13:56:01Z

Contexts can now be aborted. Any running source.get_entries will also abort their async coroutine when their context is aborted. e7872be

bluz71 · 2023-05-23T06:25:48Z

Just tested out your PR @folke.

Note, I am not authoritative since I only dabble in Tailwind occasionally, but this PR makes nvim-cmp absolutely buttery smooth with the Tailwind Language Server. A beautiful developer experience to code and not stall.

This PR definitely works very well alongside the previous PR; actually in my case this PR has more of an effect than the previous PR; though both compliment each other very well.

Two big thumbs up from me.

Great work @folke and @yioneko.

folke · 2023-05-23T06:51:04Z

Thanks!
@bluz71 What other PR are you referring to?

bluz71 · 2023-05-23T07:15:12Z

Thanks! @bluz71 What other PR are you referring to?

#1574, "perf(source): only filter up to 200 entries and dont use the cache"

folke · 2023-05-23T07:25:42Z

That pr has been merged already and this pr is a continuation of that pr. It depends on those changes

folke · 2023-05-23T07:26:44Z

I get what you mean now 🙂 Yes, this pr will have a bigger effect. The other pr mainly fixed a memory leak

…ecked before

lua/cmp/config/default.lua

lua/cmp/utils/async.lua

lua/cmp/view.lua

lua/cmp/source.lua

hrsh7th · 2023-05-25T15:02:54Z

Thank you so much for your PR!

…me allowed to run in one loop step

folke · 2023-05-25T16:26:40Z

@hrsh7th did most of the requested changes. For the rest, see my comments. Thank you for reviewing!

lua/cmp/entry.lua

lua/cmp/utils/async.lua

hrsh7th · 2023-05-25T17:46:06Z

It's perfect to me! Thank you again!

folke · 2023-05-25T17:58:07Z

Awesome, thank you for merging!

…indow * upstream/main: (31 commits) fix entry highlight in complete-menu (hrsh7th#1593) Remove max_item_count from source configuration feat: cmp async (hrsh7th#1583) ghost text inline (hrsh7th#1588) Fix demo video in README.md (hrsh7th#1585) docs: fix adjecent typo (hrsh7th#1577) docs: fix typos, add confirm.behavior example cfg (hrsh7th#1576) perf(source): only filter up to 200 entries and dont use the cache (hrsh7th#1574) fix(ghost_text): safely apply virtual_text highlight (hrsh7th#1563) Improve misc.merge Fix hrsh7th#897 Added a modified=false to documentation buffer, so it can be removed without E89 errors (hrsh7th#1557) Fix hrsh7th#1556 fix 1533, add regression test (hrsh7th#1558) Add `buftype=nofile` for entries_win and docs_win - reddit user mention this... Fix hrsh7th#1550 Format with stylua Add test for hrsh7th#1552 Close hrsh7th#1552 Revert hrsh7th#1534 temporaly fix typo (hrsh7th#1551) ...

This is because after hrsh7th/nvim-cmp#1583 was merged, plugins that cannot work within the lua event loop cause an error.

folke force-pushed the async branch 5 times, most recently from a2b7e07 to b23ad7c Compare May 21, 2023 16:39

folke force-pushed the async branch from b23ad7c to 17885d5 Compare May 21, 2023 20:27

perf: cmp is now async

1ceb2d5

folke force-pushed the async branch from 17885d5 to 1ceb2d5 Compare May 21, 2023 20:34

yioneko reviewed May 22, 2023

View reviewed changes

lua/cmp/utils/async.lua Outdated Show resolved Hide resolved

lua/cmp/utils/async.lua Show resolved Hide resolved

lua/cmp/source.lua Outdated Show resolved Hide resolved

yioneko reviewed May 22, 2023

View reviewed changes

folke added 2 commits May 22, 2023 08:13

perf(async): aggregate time budget over all async tasks

ed62364

feat: sort full entry list and slice before sending to view

d1136e5

folke force-pushed the async branch from 82c280c to d1136e5 Compare May 22, 2023 06:55

folke mentioned this pull request May 22, 2023

high ram and cpu usage with tailwindcss #1009

Closed

2 tasks

perf: context can now be aborted. Used in source.get_entries with `…

e7872be

…async.abort`

folke added 5 commits May 23, 2023 12:49

perf: check self.entries instead of self.get_entries in source complete

6c3f77a

perf: optimized check for onetime config

67bfdfe

perf: no longer needed to wrap source.complete in async

3c62fd3

test: fixed tests again. No longer need to await the results of complete

0e7305d

fix: core.complete no longer needs to be async

f55acc5

perf: only check vimitem match when needed and only match when not ch…

b221a4b

…ecked before

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/config/default.lua Outdated Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/utils/async.lua Outdated Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/utils/async.lua Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/utils/async.lua Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/utils/async.lua Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/utils/async.lua Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/view.lua Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/source.lua Outdated Show resolved Hide resolved

folke added 4 commits May 25, 2023 18:13

feat(performance): added performance.async_budget to control max ti…

a839071

…me allowed to run in one loop step

refactor(async): split await in await and sync

ccb8259

fix(async): throw when yielding from an non-yieldable context

4e9b3a2

fix(view): set view max_items default to 200

06bc8e4

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/entry.lua Show resolved Hide resolved

hrsh7th reviewed May 25, 2023

View reviewed changes

lua/cmp/utils/async.lua Show resolved Hide resolved

folke added 3 commits May 25, 2023 18:40

refactor: view.max_items => performance.max_view_entries

bb20ce3

fix(async): use vim.notify for errors that happen in throttle

f0d5cb9

perf: only cache last get_entries

c0bf17c

hrsh7th merged commit abb5c75 into hrsh7th:main May 25, 2023

TwIStOy mentioned this pull request May 26, 2023

fix entry highlight in complete-menu #1593

Merged

bew mentioned this pull request May 26, 2023

E5560: nvim_buf_get_option must not be called in a lua loop callback #1594

Closed

2 tasks

choplin added a commit to choplin/dotfiles that referenced this pull request May 28, 2023

Disable cmp-look

9ddee9d

This is because after hrsh7th/nvim-cmp#1583 was merged, plugins that cannot work within the lua event loop cause an error.

Sammyalhashe mentioned this pull request Jun 2, 2023

Adding check for isyieldable. #1607

Closed

mgnsk mentioned this pull request Jun 16, 2023

Input delay when using ray-x/lsp_signature.nvim #1613

Open

2 tasks

mortezadadgar mentioned this pull request Feb 17, 2024

TailwindCSS performance issues #1828

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cmp async #1583

feat: cmp async #1583

folke commented May 21, 2023 •

edited

Loading

folke commented May 21, 2023

folke commented May 21, 2023

yioneko commented May 22, 2023

yioneko left a comment

folke commented May 22, 2023

folke commented May 22, 2023

bluz71 commented May 23, 2023

folke commented May 23, 2023

bluz71 commented May 23, 2023

folke commented May 23, 2023

folke commented May 23, 2023

hrsh7th commented May 25, 2023

folke commented May 25, 2023

hrsh7th commented May 25, 2023

folke commented May 25, 2023

feat: cmp async #1583

feat: cmp async #1583

Conversation

folke commented May 21, 2023 • edited Loading

folke commented May 21, 2023

folke commented May 21, 2023

yioneko commented May 22, 2023

yioneko left a comment

Choose a reason for hiding this comment

folke commented May 22, 2023

folke commented May 22, 2023

bluz71 commented May 23, 2023

folke commented May 23, 2023

bluz71 commented May 23, 2023

folke commented May 23, 2023

folke commented May 23, 2023

hrsh7th commented May 25, 2023

folke commented May 25, 2023

hrsh7th commented May 25, 2023

folke commented May 25, 2023

folke commented May 21, 2023 •

edited

Loading