Enable debugger / breakpoints / stepping on ARM / ARM64 #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix some race conditions with the cond vars.
This includes Android.
Sometimes temp breakpoints had log set by accident.
Fixes menu hangs since the refactor.
This doesn't seem needed and has been there since day 1.
Memory breakpoints not yet really tested.
8 tasks
hrydgard
reviewed
Jun 7, 2018
| @@ -320,7 +331,6 @@ void Core_Run(GraphicsContext *ctx) { | |||
|
|
|||
| void Core_EnableStepping(bool step) { | |||
| if (step) { | |||
| sleep_ms(1); | |||
|
I guess #395ac32 might lose a tiny bit of performance but I doubt it's significant. This looks really good to me. |
hrydgard
approved these changes
Jun 7, 2018
|
Yeah, should be pretty slight given that the array will be empty most of the time. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the core run loop so that it takes into account CORE_STEPPING.
One possible impact of this might be issues if the game hits CORE_STEPPING - I'm not sure exactly what we would've done before, but now we'll stall waiting for a debugger to attach. Maybe if the remote debugger setting is off on mobile we should immediately exit the game?
This also makes single stepping more reliable, locking properly and using a counter so individual stepping events can correctly be identified. This fixes some race conditions that are more common when debugging remotely with higher latency.
-[Unknown]