Reimplement framebuffer reinterpret on the new color copy framework #15892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
GE emulation
hrydgard
force-pushed
the
rework-reinterpret
branch
2 times, most recently
from
49e0a80 to
b0c6082
Compare
hrydgard
force-pushed
the
rework-reinterpret
branch
from
f023213 to
ee1a3cc
Compare
4 tasks
hrydgard
force-pushed
the
rework-reinterpret
branch
from
ee1a3cc to
048a556
Compare
| // OK, now resolve it so we can texture from it. | ||
| // This will do any necessary reinterprets. | ||
| CopyToColorFromOverlappingFramebuffers(vfb); | ||
| // Now we consider the resolved one the latest at the address (though really, we could make them equivalent?). |
There was a problem hiding this comment.
Hm, I think equivalent would be better. Maybe it's a slightly older one. This does imply we chose it as the newest one, but there may be cases of partial overlap this gets wrong.
-[Unknown]
Open
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to framebuffer sequence numbers, we can now safely pretend to overlap multiple framebuffers with different formats in memory. This gets rid of "drawnFormat" and having to copy to a temporary to do reinterpret, instead we just bounce between these multiple framebuffers belonging to one address.
This makes reinterpret quite a bit faster and safer, and makes the code easier to understand and reason about, benefiting the upcoming features (32<->16 bit reinterpret, for example).
This still respects the same compat flags as before, but the goal is to get rid of them and always enable reinterpret in a later commit.
Left to do before review: