-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakpoint window #2584
Breakpoint window #2584
Conversation
Cool. For the things not loaded/saved, which do you need support for? I think it's not necessary to have multiple memchecks on the same start/end, or multiple breakpoints at the same address. You can enable/disable breakpoints with If they're editing from the list, might as well just use the initial values from the displayed memcheck/breakpoint vector. Otherwise, I guess it could have an accessor which takes references to get the current settings based on breakpoint address or memcheck start/end. To change a breakpoint address or memcheck start/end, just remove and re-add. Note that the -[Unknown] |
It's mostly minor stuff. I didn't want to mess with the breakpoint class in case you had something in the works for it. I'll remove and later add breakpoints when editing them, though I'll add that functionality later on. The breakpoint window class has some code to change breakpoints, but it's not used yet. I'll probably need to redo the way I do it anyway. |
For conditions, could just store the original string and the expression both in the BreakPointCond struct. I tried to make all the changes necessary to easily hook it up, but let me know if anything else is needed (or just change it if you'd prefer.) I'm not currently planning any more changes. Edit: I take it back, except scheduling an invalidate via CoreTiming when a breakpoint is set during jit. -[Unknown] |
Alright, I'll do that tomorrow then. |
Conditions work now. |
This adds a window for defining breakpoints, opened by clicking on the breakpoint button in the disassembly view.
The whole dialog content is evaluated, but a few things aren't loaded from or saved to breakpoints/memchecks yet because they have yet to be fully implemented there.