Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbian: Fix a crash when PSMF version is set to basic. Fixes #6103 #6181

Closed
wants to merge 1 commit into from

Conversation

xsacha
Copy link
Collaborator

@xsacha xsacha commented May 29, 2014

Just do nothing instead.

@xsacha xsacha changed the title Symbian: Fix a crash when PSMF version is set to basic. Symbian: Fix a crash when PSMF version is set to basic. Fixes #6103 May 29, 2014
@unknownbrackets
Copy link
Collaborator

This is wrong and tests slow the correct version. Where does it crash? Surely it's not setting the value here?

-[Unknown]

@sum2012
Copy link
Collaborator

sum2012 commented May 29, 2014

If cannot solve, can add
ifndef SYMBIAN32 instead

@unknownbrackets
Copy link
Collaborator

Well, "setting a variable to 1 instead of 0 causes a crash" sounds really crazy. If this is a bug, I want to know what it is, but it works on all other platforms afaik and I don't understand why it would crash on Symbian.

There's plenty of other variables I'd like to be able to set to 1. What's to stop those from causing crashes?

-[Unknown]

Verified

This commit was signed with the committer’s verified signature. The key has expired.
miri64 Martine Lenders
@richz00
Copy link

richz00 commented Jun 5, 2014

Harvest moon HOLV has fixed but Sid Meier Pirates crash after opening , Mimana Iyar crash after select new game, Final Fantasy type 0 crash,. PPSSPP-v0.9.8-238-gd8df88b is best version for symbian until now.

@xsacha
Copy link
Collaborator Author

xsacha commented Jun 5, 2014

What about 0.9.8-414? Technically it shouldnt have these Psmf crashes?

@xsacha
Copy link
Collaborator Author

xsacha commented Jun 5, 2014

Something interesting..
I compiled PPSSPP in debug mode and connected gdb up to it..
No crash.
Compile again in release mode, it crashes!

This will be hard to track down.

@danpio
Copy link

danpio commented Jun 5, 2014

holding thumbs up :) fight! Will there be a version for MeeGo? community will wait - he believes in the success :)

@xsacha
Copy link
Collaborator Author

xsacha commented Jun 5, 2014

@danpio
Well Meego compiles, it just needs ffmpeg.

I didn't want to pollute the ffmpeg dir with heaps of ARM binaries so I was wondering if maemo/meego/pandora/raspberry pi could actually share the same ffmpeg binary(ies). They are all linux-arm-gnueabi so they should be able to correct?

In that case, I'm not sure what is the best ./configure arguments to build for all of them (raspberry pi needs armv6, maemo/meego need armv7).
I am hoping someone from the meego community comes forth with a proper ffmpeg build. Then I will happily continue automatic builds.

@danpio
Copy link

danpio commented Jun 5, 2014

I have such a package https://packages.debian.org/squeeze/armel/ffmpeg/download
I want to test binaries PPSSPP - debugging is not foreign to me :)

@xsacha
Copy link
Collaborator Author

xsacha commented Jun 5, 2014

@danpio That ffmpeg is ancient. v0.5? I think we use v1.2.
It needs to be compiled from the ppsspp-ffmpeg repo. Also, it should be based off the configure flags that Android uses (but without all its weird defines).
PPSSPP needs some special things that aren't in run-of-the-mill ffmpeg builds.

I think I will grab some generic arm compiler, but I'm not sure if getting one that is too new will break compatibility. Any ideas?

@unknownbrackets I debugged in release mode but it can't tell me very much.

37:15:276 user_main I[MODULE]: HLE/sceKernelModule.cpp:1639 292=sceKernelLoadModule(name=disc0:/PSP_GAME/USRDIR/libpsmfplayer.prx,flag=00000000,(...))
37:15:277 user_main I[MODULE]: HLE/sceKernelModule.cpp:1670 sceKernelStartModule(292,asize=00000000,aptr=00000000,retptr=00000000,00000000): faked (undecryptable module)
37:15:277 user_main I[ME]: HLE/scePsmf.cpp:994 scePsmfPlayerCreate(08ffd250, 08ffd254)
37:15:279 user_main I[ME]: HLE/scePsmf.cpp:1918 scePsmfPlayerConfigPlayer(08ffd250, loop, 1)
37:15:280 user_main I[ME]: HLE/scePsmf.cpp:1926 scePsmfPlayerConfigPlayer(08ffd250, pixelType, 3)
37:15:280 user_main I[KERNEL]: HLE/sceKernelThread.cpp:2145 293=sceKernelCreateThread(name=PSMFAudio, entry=0895a2fc, prio=20, stacksize=2048)
37:15:280 user_main W[ME]: HLE/scePsmf.cpp:1219 8192 = scePsmfPlayerGetAudioOutSize(08ffd250)
Thread 1475 stopped: 'Exception': A data abort exception has occurred accessing 0x3e3c096.

*stopped,reason="signal-received",signal-name="SIGSEGV",signal-meaning="Segmentation fault",frame={addr="0xfc1c4082",func="??",args=[]},thread-id="1",stopped-threads="all"
NOTE: INFERIOR SPONTANEOUS STOP
Disassembler failed: Cannot access memory at address 0xfc1c406e

Backtrace just shows question marks.. The final address is always the same though:

~"#0 0xfc1c4082 in ?? ()

@danpio
Copy link

danpio commented Jun 5, 2014

good, I will not bother you - I'm waiting alone :)

@xsacha
Copy link
Collaborator Author

xsacha commented Jun 5, 2014

Looks like @unknownbrackets changes fixed this...

@xsacha xsacha closed this Jun 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants