Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use set use_agent, but set gpg binary to gpg2 #9

Closed
wants to merge 1 commit into from

Conversation

mrtndwrd
Copy link

At least in my setup, use_agent does not have to be manually set to "true" to make this work, I think gpg2 uses it by default.. python-gnupg uses gpg1 by default though, which, to me, does not make sense. Therefore I changed it to gpg2. This is tested on Ubuntu 16.04, not on any other platform

don't set use_agent, set binary to gpg2

At least in my setup, use_agent does not have to be manually set to "true" to make this work, I think gpg2 uses it by default.. `python-gnupg` uses gpg1 by default though, which, to me, does not make sense. Therefore I changed it to gpg2. This is tested on Ubuntu 16.04, not on any other platform
@mrtndwrd mrtndwrd mentioned this pull request Jul 26, 2017
@hsanson
Copy link
Owner

hsanson commented Jul 27, 2017

Thanks for the MR but I think I cannot accept this as it is now. This can potentially break the extension for users that do use the gpg binary (e.g. me) instead of the gpg2 binary.

When time allows I will implement a configuration page for the plugin to allow users select the binary they want to use and possibly other stuff like the password store location.

@hsanson hsanson closed this Jul 27, 2017
@mrtndwrd
Copy link
Author

I get that. If you want I can add the gpgbinary to the python program as a command line argument. I don't have any experience with chrome extensions though, so I wouldn't know how to fix that part of the application

@hsanson
Copy link
Owner

hsanson commented Jul 28, 2017

The extension (javascript) invokes the nativePass application with a single argument that contains binary format (protobuf). There is no way to tell the extension to pass additional arguments (e.g. gpgbinary) so this won't help. Thanks for the offer anyway.

I need to first create a configuration dialog for the extension that allows users to select/set the full binary path and then modify all sections that call the native app (message_send) to include the binary path as argument.

This was referenced Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants