Skip to content

Commit

Permalink
fix(ingest/dbt): enable incremental lineage by default
Browse files Browse the repository at this point in the history
This reverts datahub-project#6467.
  • Loading branch information
hsheth2 committed Mar 23, 2023
1 parent 4ec34fc commit aabdd6c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
1 change: 1 addition & 0 deletions docs-website/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

/docs
/genDocs
/genStatic

# Generated GraphQL
/graphql/combined.graphql
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,6 @@ class DBTCommonConfig(
description='Regex string to extract owner from the dbt node using the `(?P<name>...) syntax` of the [match object](https://docs.python.org/3/library/re.html#match-objects), where the group name must be `owner`. Examples: (1)`r"(?P<owner>(.*)): (\\w+) (\\w+)"` will extract `jdoe` as the owner from `"jdoe: John Doe"` (2) `r"@(?P<owner>(.*))"` will extract `alice` as the owner from `"@alice"`.',
)

incremental_lineage: bool = Field(
# Copied from LineageConfig, and changed the default.
default=False,
description="When enabled, emits lineage as incremental to existing lineage already in DataHub. When disabled, re-states lineage on each run.",
)
include_env_in_assertion_guid: bool = Field(
default=False,
description="Prior to version 0.9.4.2, the assertion GUIDs did not include the environment. If you're using multiple dbt ingestion "
Expand Down
3 changes: 0 additions & 3 deletions metadata-ingestion/tests/integration/dbt/test_dbt.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ def set_paths(
self.output_path = f"{tmp_path}/{self.output_file}"

self.golden_path = f"{test_resources_dir}/{self.golden_file}"

self.source_config_modifiers.setdefault("incremental_lineage", True)
self.source_config = dict(
{
"manifest_path": self.manifest_path,
Expand Down Expand Up @@ -254,7 +252,6 @@ def test_dbt_tests(pytestconfig, tmp_path, mock_time, **kwargs):
),
# this is just here to avoid needing to access datahub server
write_semantics="OVERRIDE",
incremental_lineage=True,
),
),
sink=DynamicTypedConfig(type="file", config={"filename": str(output_file)}),
Expand Down

0 comments on commit aabdd6c

Please sign in to comment.