Skip to content

Commit

Permalink
chore(ingest): remove outdated GE compatibility hack (datahub-project…
Browse files Browse the repository at this point in the history
  • Loading branch information
hsheth2 committed Sep 8, 2022
1 parent 23f4175 commit fb94a93
Showing 1 changed file with 3 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,8 @@
import uuid
from typing import Any, Callable, Dict, Iterable, Iterator, List, Optional, Tuple, Union

from great_expectations import __version__ as ge_version

from datahub.configuration.common import ConfigurationError
from datahub.telemetry import stats, telemetry

# Fun compatibility hack! GE version 0.13.44 broke compatibility with SQLAlchemy 1.3.24.
# This is a temporary workaround until GE fixes the issue on their end.
# See https://github.com/great-expectations/great_expectations/issues/3758.
try:
import sqlalchemy.engine
from sqlalchemy.engine.url import make_url

sqlalchemy.engine.make_url = make_url # type: ignore
except ImportError:
pass

import sqlalchemy as sa
from great_expectations import __version__ as ge_version
from great_expectations.core.util import convert_to_json_serializable
from great_expectations.data_context import BaseDataContext
from great_expectations.data_context.types.base import (
Expand All @@ -43,6 +28,7 @@
from sqlalchemy.exc import ProgrammingError
from typing_extensions import Concatenate, ParamSpec

from datahub.configuration.common import ConfigurationError
from datahub.emitter.mce_builder import get_sys_time
from datahub.ingestion.source.ge_profiling_config import GEProfilingConfig
from datahub.ingestion.source.profiling.common import (
Expand All @@ -58,6 +44,7 @@
QuantileClass,
ValueFrequencyClass,
)
from datahub.telemetry import stats, telemetry
from datahub.utilities.perf_timer import PerfTimer
from datahub.utilities.sqlalchemy_query_combiner import (
SQLAlchemyQueryCombiner,
Expand Down

0 comments on commit fb94a93

Please sign in to comment.