Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contribution guide #120

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Improve contribution guide #120

merged 1 commit into from
Apr 20, 2024

Conversation

hsloot
Copy link
Owner

@hsloot hsloot commented Apr 20, 2024

Related issues

None

Checklist

  • R CMD CHECK successful
  • Tests included
  • Documentation included or updated
  • Commit messages follow commit guidelines

Optional, but recommended:

  • Code passes lintr::lint_package() without errors

Description

Proposed changes:

  • Add paragraph on continuous benchmarks
  • Minor editorial changes

Copy link

Benchmark summary

File Expression Min time Median time Mem. alloc
armageddon-15.R Armageddon 575µs (-0.79%) 594µs (-0.75%) 120KB (-41.18%)
armageddon-15.R Arnold 1.64ms (-0.61%) 1.7ms (-0.58%) 120KB (-10.45%)
armageddon-15.R ESM 736µs (-0.19%) 747µs (-0.72%) 120KB (-1.64%)
armageddon-15.R ExMarkovian 893µs (-0.96%) 927µs (-0.54%) 120KB (-14.29%)
armageddon-15.R LFM 862µs (-0.99%) 878µs (-0.78%) 120KB (-2.44%)
pareto-125.R ExMarkovian 6.2ms (-0.32%) 6.33ms (-0.31%) 979KB (0.00%)
pareto-125.R LFM 12.5ms (-0.48%) 12.7ms (-0.62%) 979KB (0.00%)
pareto-15.R Arnold 1.83ms (0.55%) 1.88ms (-0.53%) 120KB (0.00%)
pareto-15.R ExMarkovian 968µs (0.46%) 996µs (-0.40%) 120KB (0.00%)
pareto-15.R LFM 3.63ms (0.28%) 3.76ms (-0.27%) 120KB (0.00%)
poisson-15.R Arnold 1.9ms (0.00%) 1.94ms (0.00%) 120KB (0.00%)
poisson-15.R ExMarkovian 1ms (-0.99%) 1.02ms (-0.97%) 120KB (0.00%)
poisson-15.R LFM 1.18ms (0.00%) 1.2ms (-0.83%) 120KB (0.00%)

@hsloot hsloot merged commit 12f696f into main Apr 20, 2024
10 checks passed
@hsloot hsloot deleted the docs-improve-contrib-guide branch April 20, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant