Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group info page: "Other group" logic improvements #387

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

towerofnix
Copy link
Member

This PR tweaks the "from (some other group)" element on group info pages, mostly to improve support albums belonging to two or more groups of the same category (e.g. "Solo musicians"). Details:

  • We no longer display groups from the same category as the current group belongs to. (We select the first non-same group, top-down, same direction as before.)
  • We'll now display more than one group from the same category, if applicable. (That is, if the album belongs to multiple groups under the category selected above.)

Examples:

Albums from the Official Discography, such as Hiveswap Act 1 OST (from James Roach and Toby Fox) Albums from James Roach, such as Hiveswap Act 1 OST (from Official Discography)

* Always selects from a different category than the current one.
* Will select & display multiple groups from the same category.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant