Fix Projects, Some restructuring of OptionsDialog #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for squashing your commits, but using the web editor to fix the conflict (and in so generating a merge commit) was an error on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built upon the behaviour that Iaito saves projects for a file called _. When opening a file and a project matching the filename exists, it will be opened and the OptionsDialog will be skipped (resolves #152).
For this, I changed how OptionsDialog behaves. Instead of the OptionsDialog creating the MainWindow, one would create a MainWindow and call
MainWindow::openFile(const QString &fn, int anal_level)on it, which then will take care of either opening a project or showing an OptionsDialog.I also added a Settings class to prevent typos in the settings names.
Please note that projects will be corrupted with the radare2 1.4.0 from the submodule. One bug that breaks afC has already been fixed in radare2 git, another one that currently breaks notes in Iaito will be fixed by radareorg/radare2#7485.