adjusted numpy version #1015
Merged
adjusted numpy version #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrl-z-9000-times
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
This looks good to me. Thank you for bumping the versions and checking that it still works!
As for the latest numpy release:
- It's very new. I think we should wait a month or two before dealing with it, just to let the numpy team shake out any issues on their end.
- It would be nice if htm.core worked with both numpy v1 and v2. I checked the release notes and I think that should be doable, but it might take a few changes on our end?
Does this sound like a reasonable plan of action?
|
ok, we will stay with numpy v1 for a little while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version number adjustments.
however I found that the latest numpy version requires at least Python 3.9.
I adjusted the requirements.txt to limit the version of numpy to V1.23 so that the minimum remains at Python V3.7.
However, we could also change the minimum Python version to Python 3.9, then we can use the latest numpy. But on Ubuntu 22.04 (and probably others as well) the default is Python 3.8 and the build fails unless a newer Python is installed.
The HelloSPTPTest regression test still fails. This is a performance test. However, on my slow machine (Intel i7 gen8) it runs too slow to pass the test. It would be good to have a performance test that flags a PR that destroys performance but the test should not be dependent on the processor's speed. So for now I disabled that test.
I also made some corrections to the README file.