Yaml Crash Problem WIP

external/bootstrap.cmake

@@ -29,16 +29,18 @@
 #  - create build/scripts (mkdir -d build/scripts)
 #  - cd build/scripts
 #  - cmake ../..
+#
+# externals are always built in Release mode, CMake's build type is ignored
 
 
 
 FILE(MAKE_DIRECTORY  ${REPOSITORY_DIR}/build/ThirdParty)
 execute_process(COMMAND ${CMAKE_COMMAND} 
-                        -G ${CMAKE_GENERATOR}
-			-D CMAKE_INSTALL_PREFIX=. 
-                        -D NEEDS_BOOST:BOOL=${NEEDS_BOOST}
-                        -D BINDING_BUILD:STRING=${BINDING_BUILD}
-			-D CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
+            -G ${CMAKE_GENERATOR}
+	    -D CMAKE_INSTALL_PREFIX=. 
+            -D NEEDS_BOOST:BOOL=${NEEDS_BOOST}
+            -D BINDING_BUILD:STRING=${BINDING_BUILD}
+	    -D CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
 			 ../../external
                 WORKING_DIRECTORY ${REPOSITORY_DIR}/build/ThirdParty
                 RESULT_VARIABLE result
@@ -47,36 +49,15 @@ execute_process(COMMAND ${CMAKE_COMMAND}
 if(result)
     message(FATAL_ERROR "CMake step for Third Party builds failed: ${result}")
 endif()
-if(MSVC)
-  # for MSVC builds we need to build both Release and Debug builds
-  # because this will not be ran again if we switch modes in the IDE.
-  execute_process(COMMAND ${CMAKE_COMMAND} --build . --config Release 
-                    WORKING_DIRECTORY ${REPOSITORY_DIR}/build/ThirdParty
-                    RESULT_VARIABLE result
-#                    OUTPUT_QUIET      ### Disable this to debug external buiilds
-        )
-  if(result)
-    message(FATAL_ERROR "build step for MSVC Relase Third Party builds failed: ${result}")
-  endif()
-  execute_process(COMMAND ${CMAKE_COMMAND} --build . --config Debug 
-                    WORKING_DIRECTORY ${REPOSITORY_DIR}/build/ThirdParty
-                    RESULT_VARIABLE result
-#                    OUTPUT_QUIET      ### Disable this to debug external buiilds
-        )
-  if(result)
-    message(FATAL_ERROR "build step for MSVC Debug Third Party builds failed: ${result}")
-  endif()
-else(MSVC)
-  # for linux and OSx builds
-  execute_process(COMMAND ${CMAKE_COMMAND} --build . --config ${CMAKE_BUILD_TYPE} 
+
+execute_process(COMMAND ${CMAKE_COMMAND} --build .  
                     WORKING_DIRECTORY ${REPOSITORY_DIR}/build/ThirdParty
                     RESULT_VARIABLE result
-#                    OUTPUT_QUIET      ### Disable this to debug external buiilds
+#                    OUTPUT_QUIET      ### Disable this to debug external builds
         )
   if(result)
     message(FATAL_ERROR "build step for Third Party builds failed: ${result}")
   endif()
-endif(MSVC)
 
 # extract the external directory paths
 #    The external third party modules are being built

src/nupic/engine/RegionImplFactory.cpp

@@ -116,7 +116,7 @@ RegionImpl *RegionImplFactory::createRegionImpl(const std::string nodeType,
 
   RegionImpl *impl = nullptr;
   std::shared_ptr<Spec>& ns = getSpec(nodeType);
-  ValueMap vm = YAMLUtils::toValueMap(nodeParams.c_str(), ns->parameters,
+  ValueMap vm = YAMLUtils::toValueMap(nodeParams, ns->parameters,
                                       nodeType, region->getName());
 
   if (regionTypeMap.find(nodeType) != regionTypeMap.end()) {

src/nupic/engine/YAMLUtils.cpp

@@ -89,6 +89,7 @@ static void _toArray(const YAML::Node& node, std::shared_ptr<Array>& a) {
 
   a->allocateBuffer(node.size());
   void *buffer = a->getBuffer();
+  NTA_CHECK(buffer != nullptr) << "buffer is null";
 
   for (size_t i = 0; i < node.size(); i++) {
     const YAML::Node &item = node[i];
@@ -165,14 +166,15 @@ static Value toValue(const YAML::Node &node, NTA_BasicType dataType) {
 Value toValue(const std::string& yamlstring, NTA_BasicType dataType)
 {
   // TODO -- return value? exceptions?
+  NTA_CHECK(yamlstring.size() > 0) << "string is empty!";
   const YAML::Node doc = YAML::Load(yamlstring);
   return toValue(doc, dataType);
 }
 
 /*
  * For converting param specs for Regions and LinkPolicies
  */
-ValueMap toValueMap(const char *yamlstring,
+ValueMap toValueMap(const std::string yamlstring,
                     Collection<ParameterSpec> &parameters,
                     const std::string &nodeType,
                     const std::string &regionName) {
@@ -276,11 +278,6 @@ ValueMap toValueMap(const char *yamlstring,
         // }
 
         try {
-#ifdef YAMLDEBUG
-          NTA_DEBUG << "Adding default value '" << ps.defaultValue
-                    << "' to parameter " << item.first << " of type "
-                    << BasicType::getName(ps.dataType) << " count " << ps.count;
-#endif
           // NOTE: this can handle both scalers and arrays
           //       Arrays MUST be in Yaml sequence format even if one element.
           //       i.e.  [1,2,3]

src/nupic/engine/YAMLUtils.hpp

@@ -41,7 +41,7 @@ namespace nupic
 /*
  * For converting param specs for Regions and LinkPolicies
  */
-ValueMap toValueMap(const char *yamlstring,
+ValueMap toValueMap(const std::string yamlstring,
                     Collection<ParameterSpec> &parameters,
                     const std::string &nodeType = "",
                     const std::string &regionName = "");