-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove simpletree
from the package
#45
Conversation
…builder is `dom` now
…builder is `dom` now
…builder is `dom` now
…builder is `dom` now
And merged in 96da7f5. |
Is there any discussion of why this change was made anywhere? I wasn't able to find anything on html5lib-discuss. |
The discussion was on IRC. Basically the feeling was that simpletree isn't production quality and there is not enough benefit in maintaining our own tree format just for testing. |
And related to that, it has proved at several points to be quite a lot of work to maintain, when really it serves almost nobody: we support two tree APIs in the stdlib which should suffice in general. |
Well, I'll disagree with "when really it serves almost nobody" because it was incredibly helpful in Bleach, and getting around the removal (mozilla/bleach#94) is going to pin me and bleach users to 0.96 for a while. I understand the reasons, but it would be great to document hugely-API-breaking changes' decision process. |
Well, what do you gain by using simpletree instead of e.g., minidom or ElementTree? I don't think there's any case in which simpletree is the right choice — thus "it serves almost nobody". |
This also breaks django_compressor in a non-trivial way: django-compressor/django-compressor#405 |
django-compressor/django-compressor#405 is fixed, switched to using the default etree builder and walker. |
Thanks, @ambv! |
The default tree builder is now
etree
. I also added an "implementation" attribute to the TreeBuilder API so you can select the correctElementTree
if you have to access it. In related news, I started a change log, to be filled out before releasing 1.0 proper.