Merge pull request #694 from danicheg/scalafix

Set up Scalafix and bump `sbt-http4s-org` version

.github/workflows/ci.yml

@@ -9,9 +9,9 @@ name: Continuous Integration
 
 on:
   pull_request:
-    branches: ['**']
+    branches: ['**', '!update/**']
   push:
-    branches: ['**']
+    branches: ['**', '!update/**']
     tags: [v*]
 
 env:
@@ -87,6 +87,10 @@ jobs:
       - name: Check Java formatting
         run: sbt '++${{ matrix.scala }}' '${{ matrix.ci }}' javafmtCheckAll
 
+      - name: Check scalafix lints
+        if: matrix.java == 'temurin@8' && !startsWith(matrix.scala, '3.')
+        run: sbt '++${{ matrix.scala }}' 'scalafixAll --check'
+
       - name: Check unused compile dependencies
         if: matrix.java == 'temurin@8'
         run: sbt '++${{ matrix.scala }}' unusedCompileDependenciesTest

.scalafix.blaze.conf

@@ -0,0 +1,7 @@
+rules = [
+  RedundantSyntax
+]
+
+triggered.rules = [
+  RedundantSyntax
+]

.scalafix.conf

@@ -0,0 +1,15 @@
+rules = [
+  Http4sFs2Linters
+  Http4sGeneralLinters
+  Http4sUseLiteralsSyntax
+  LeakingImplicitClassVal
+  ExplicitResultTypes
+  OrganizeImports
+]
+
+triggered.rules = [
+  Http4sFs2Linters
+  Http4sGeneralLinters
+  Http4sUseLiteralsSyntax
+  LeakingImplicitClassVal
+]

.scalafix.test.conf

@@ -0,0 +1,12 @@
+rules = [
+  Http4sGeneralLinters
+  Http4sUseLiteralsSyntax
+  LeakingImplicitClassVal
+  OrganizeImports
+]
+
+triggered.rules = [
+  Http4sGeneralLinters
+  Http4sUseLiteralsSyntax
+  LeakingImplicitClassVal
+]

blaze-client/src/test/scala/org/http4s/blaze/client/BlazeClientBase.scala

@@ -20,8 +20,8 @@ package client
 import cats.effect._
 import cats.effect.kernel.Resource
 import cats.effect.std.Dispatcher
-import cats.syntax.all._
 import cats.implicits.catsSyntaxApplicativeId
+import cats.syntax.all._
 import fs2.Stream
 import io.netty.channel.ChannelHandlerContext
 import io.netty.handler.codec.http.HttpMethod

build.sbt

@@ -54,7 +54,8 @@ lazy val commonSettings = Seq(
     }
   },
   run / fork := true,
-  scalafmtConfig := file(".scalafmt.blaze.conf")
+  scalafmtConfig := file(".scalafmt.blaze.conf"),
+  scalafixConfig := Some(file(".scalafix.blaze.conf"))
 )
 
 // currently only publishing tags
@@ -168,7 +169,8 @@ lazy val blazeCore = project
             .exclude[DirectMissingMethodProblem]("org.http4s.blazecore.util.IdentityWriter.ec")
         )
       else Seq.empty
-    }
+    },
+    Test / scalafixConfig := Some(file(".scalafix.test.conf"))
   )
   .dependsOn(http)
 
@@ -231,7 +233,8 @@ lazy val blazeServer = project
           )
         )
       else Seq.empty,
-    }
+    },
+    Test / scalafixConfig := Some(file(".scalafix.test.conf"))
   )
   .dependsOn(blazeCore % "compile;test->test")
 
@@ -328,7 +331,8 @@ lazy val blazeClient = project
           )
         )
       else Seq.empty
-    }
+    },
+    Test / scalafixConfig := Some(file(".scalafix.test.conf"))
   )
   .dependsOn(blazeCore % "compile;test->test")
 
@@ -341,7 +345,8 @@ lazy val examples = Project("blaze-examples", file("examples"))
       "org.http4s" %% "http4s-dsl" % http4sVersion,
       "org.http4s" %% "http4s-circe" % http4sVersion,
       "io.circe" %% "circe-generic" % "0.14.2"
-    )
+    ),
+    Test / scalafixConfig := Some(file(".scalafix.test.conf"))
   )
   .dependsOn(blazeServer, blazeClient)
 

project/plugins.sbt

@@ -1,5 +1,5 @@
 addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.11.0")
 addSbtPlugin("com.lightbend.sbt" % "sbt-java-formatter" % "0.7.0")
 addSbtPlugin("io.spray" % "sbt-revolver" % "0.9.1")
-addSbtPlugin("org.http4s" %% "sbt-http4s-org" % "0.13.4")
+addSbtPlugin("org.http4s" %% "sbt-http4s-org" % "0.14.2")
 addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "1.0.0")