-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Scalafix and bump sbt-http4s-org
version
#694
Merged
+52
−9
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8473f17
Add .scalafix.conf
danicheg 877d83b
Add .scalafix.test.conf
danicheg 8d3b151
Bump sbt-http4s-org version
danicheg d5bc6c1
Set Scalafix config for Test in build.sbt
danicheg 2ab289e
Regenerate ci.yml
danicheg 64f09af
Disable Scalafix for old modules
danicheg 04688e4
Introduce dummy config for old blaze modules
danicheg 7ccd481
A manual fix of BlazeClientBase to satisfy scalafix at CI
danicheg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
rules = [ | ||
RedundantSyntax | ||
] | ||
|
||
triggered.rules = [ | ||
RedundantSyntax | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
rules = [ | ||
Http4sFs2Linters | ||
Http4sGeneralLinters | ||
Http4sUseLiteralsSyntax | ||
LeakingImplicitClassVal | ||
ExplicitResultTypes | ||
OrganizeImports | ||
] | ||
|
||
triggered.rules = [ | ||
Http4sFs2Linters | ||
Http4sGeneralLinters | ||
Http4sUseLiteralsSyntax | ||
LeakingImplicitClassVal | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
rules = [ | ||
Http4sGeneralLinters | ||
Http4sUseLiteralsSyntax | ||
LeakingImplicitClassVal | ||
OrganizeImports | ||
] | ||
|
||
triggered.rules = [ | ||
Http4sGeneralLinters | ||
Http4sUseLiteralsSyntax | ||
LeakingImplicitClassVal | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
addSbtPlugin("com.eed3si9n" % "sbt-buildinfo" % "0.11.0") | ||
addSbtPlugin("com.lightbend.sbt" % "sbt-java-formatter" % "0.7.0") | ||
addSbtPlugin("io.spray" % "sbt-revolver" % "0.9.1") | ||
addSbtPlugin("org.http4s" %% "sbt-http4s-org" % "0.13.4") | ||
addSbtPlugin("org.http4s" %% "sbt-http4s-org" % "0.14.2") | ||
addSbtPlugin("org.scalastyle" %% "scalastyle-sbt-plugin" % "1.0.0") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danicheg the test config also enforces organize imports, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Then my hypothesis about Test config is wrong. But why all is good at local 🤯