Add Scala Native suppresion of unused deps #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to http4s#129, just for Scala Native this time. Had to add the corresponding sbt plugin as sbt-typelevel doesn't bring (unlike it does for JS), hope this doesn't have any negative consequences.
armanbilge
reviewed
Oct 20, 2022
There was a problem hiding this comment.
This has been annoying me as well.
Historically Scala Native has provoked more concern than enthusiasm, so I've just been inlining a fix per-project.
Co-authored-by: Arman Bilge <[email protected]>
|
Thank you for the context and the fix. As for the concerns: I can also list all dependencies, but given that Scala Native gains traction in Typelevel & http4s, I would hope we can fix this for all. |
armanbilge
reviewed
Oct 20, 2022
Co-authored-by: Arman Bilge <[email protected]>
|
If that plugin doesn't cause a problem on the modules that will never support native, centralizing the fix here seems good. |
armanbilge
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #129, just for Scala Native this time. Had to add the corresponding sbt plugin as sbt-typelevel doesn't bring (unlike it does for JS), hope this doesn't have any negative consequences.
Popped up when trying to build something with native support in http4s-fs2-data.