Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wipe timeout support out #214

Closed
ixti opened this issue Apr 27, 2015 · 2 comments
Closed

Wipe timeout support out #214

ixti opened this issue Apr 27, 2015 · 2 comments

Comments

@ixti
Copy link
Member

ixti commented Apr 27, 2015

@zanker, in face of switching socket related stuff to socketry, I propose to wipe out timeouts support. That will auto-magically resolve #203 and will bring timeouts support and better celluloid integration once we finally switch to socketry. #210 becomes obsolete as well.

@zanker
Copy link
Contributor

zanker commented Apr 27, 2015

It definitely should not be removed. For us personally, timeout support is critical, but in general a HTTP client is kind of a lot less useful if you can't control timeouts.

I do want to switch it to Socketry when that's ready, but it's not yet :(

@ixti
Copy link
Member Author

ixti commented Apr 27, 2015

Got your point. Agree on timeouts. Just wanted to see celluloid support fixed again :D

@ixti ixti closed this as completed Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants