Automatically use non-exception NIOs for improved performance #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rubbocopped! Otherwise this is incredibly cool |
| def readpartial(size) | ||
| reset_timer | ||
| # NIO with exceptions | ||
| if RUBY_VERSION < "2.1.0" |
There was a problem hiding this comment.
Perhaps these could be factored into different backends?
There was a problem hiding this comment.
I was thinking about it but I'd rather just do Socketry really. I was starting work on it last night but things blew up :(
Need to do a bit more testing on a lot of this though
zanker
force-pushed
the
zanker/exceptionless-nio
branch
from
449dba2 to
e079e86
Compare
zanker
force-pushed
the
zanker/exceptionless-nio
branch
from
e079e86 to
231c1a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a fun one. Apparently, in 2.1.x (and as such, JRuby 9k), Ruby added an undocumented arg to the NIO methods that allows you to use them without exceptions and instead symbol returns of the results. This is only available for write/read and not connect.
Quick performance test of
read_nonblockwith and without exceptions. On MRI, without exceptions is 50% faster, on JRuby it's around 85% faster. This is about inline with what we expect, exceptions in Java/JRuby are much more costly than Ruby, which are already costly.The problem like everything, is testing it is a bitch :(
cc @tarcieri @nerdrew