-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL with underscores don't work #323
Comments
My teammate thinks that this issue should be fixed in the Addressable gem. So he created a similar issue in that gem. |
Addressable has been the source of a lot of problems, I think. We've discussed removing it (or at least minimizing its usage) in a 2.0 release. |
One thing I should note on this: underscores aren't technically allowed in domain names (only |
@tarcieri You're right, they are not allowed in DNS names. Thanks! |
I suggest either fixing your URLs or fixing Addressable. |
@tarcieri I'd actually be really interested in hearing more about where Addressable has been a problem. |
@sporkmonger #297 has most of the discussion. For what it's worth I don't think we're planning on removing it anymore. |
HTTP incorrectly converts
sms_service.mysite.com
URL intosms%5Fservice.mysite.com
. And then my request fails withHTTP::ConnectionError: failed to connect: getaddrinfo: Name or service not known
error.PS. curl for the same URL works fine.
The text was updated successfully, but these errors were encountered: