Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL with underscores don't work #323

Closed
907th opened this issue Mar 29, 2016 · 7 comments
Closed

URL with underscores don't work #323

907th opened this issue Mar 29, 2016 · 7 comments
Labels

Comments

@907th
Copy link

907th commented Mar 29, 2016

HTTP incorrectly converts sms_service.mysite.com URL into sms%5Fservice.mysite.com. And then my request fails with HTTP::ConnectionError: failed to connect: getaddrinfo: Name or service not known error.
PS. curl for the same URL works fine.

@907th
Copy link
Author

907th commented Mar 29, 2016

My teammate thinks that this issue should be fixed in the Addressable gem. So he created a similar issue in that gem.

@tarcieri
Copy link
Member

Addressable has been the source of a lot of problems, I think. We've discussed removing it (or at least minimizing its usage) in a 2.0 release.

@tarcieri
Copy link
Member

One thing I should note on this: underscores aren't technically allowed in domain names (only [a-z0-9\-])

@907th
Copy link
Author

907th commented Apr 24, 2016

@tarcieri You're right, they are not allowed in DNS names. Thanks!

@tarcieri
Copy link
Member

I suggest either fixing your URLs or fixing Addressable.

@sporkmonger
Copy link

@tarcieri I'd actually be really interested in hearing more about where Addressable has been a problem.

@tarcieri
Copy link
Member

@sporkmonger #297 has most of the discussion. For what it's worth I don't think we're planning on removing it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants