Use object composition rather than inheritance for HTTP::URI #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Addressable gem has been the source of a number of bugs and performance problems. Perhaps in the future it might be worth avoiding using it where ::URI would suffice, or getting rid of it entirely, but as things stand it's the parent class for HTTP::URI, which prevents us from doing that without making a breaking release of the library. This replaces inheritence with object composition: Forwardable is used to delegate an explicit set of methods to Addressable::URI. This should make it easier to work around Addressable bugs or potentially even use ::URI as the internal representation when URIs are simple enough.
| @@ -141,7 +141,7 @@ def persistent(host) | |||
| return p_client unless block_given? | |||
| yield p_client | |||
| ensure | |||
| p_client.close | |||
| p_client.close unless p_client.nil? | |||
There was a problem hiding this comment.
👍 (probably should've done a separate commit/PR for that too, but I was lazy)
|
I think that's awesome! 👍 |
|
Sweet |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Addressable gem has been the source of a number of bugs and performance problems (e.g. #206, #297, #323)
Perhaps in the future it might be worth avoiding using it where
::URIwould suffice, or getting rid of it entirely, but as things standAddressable::URIis the parent class forHTTP::URI, which prevents us from doing that without making a breaking release of the library.This replaces inheritance with object composition:
Forwardableis used to delegate an explicit set of methods toAddressable::URI. This should make it easier to work around Addressable bugs orpotentially even use
::URIas the internal representation when URIs are simple enough.