Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation on timeouts #216

Merged
merged 1 commit into from
May 8, 2015

Conversation

zanker
Copy link
Contributor

@zanker zanker commented May 8, 2015

@ixti the docs on timeout aren't quite right (namely they need the type of timeout). Celluloid::IO works again, since the respond_to? :sync_close= change was made. Although @tarcieri should tag a new celluloid-io that has that fix in!

@ixti
Copy link
Member

ixti commented May 8, 2015

namely they need the type of timeout

That's my defect :D It was supposed to be :per_operation if not specified - but I have mistyped it ;))

ixti added a commit that referenced this pull request May 8, 2015
Updated documentation on timeouts
@ixti ixti merged commit 38fa0eb into httprb:master May 8, 2015
@sferik
Copy link
Contributor

sferik commented May 8, 2015

👍

@ixti
Copy link
Member

ixti commented May 8, 2015

Just FYI. I have fixed that defect (and covered with specs - why I didn't wrote them before - have no clue). And updated README section about that ;))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants