Code

back to io/wait#368

Code

Closed

HoneyryderChuck wants to merge 29 commits intohttprb:masterhttprb/http:masterfrom HoneyryderChuck:issue_357HoneyryderChuck/http:issue_357Copy head branch name to clipboard

+63-24

Commits

Commits on Jan 28, 2017

• reverting the previous io/wait commits as a first measure, and reproducing the previous errors

  

  Tiago Cardoso

  authored and

  Tiago Cardoso

  committed
  2590ac2

  Copy full SHA for 2590ac2

• added helper methods to the response, which will help inferring the proper content length to read from socket

  

  Tiago Cardoso

  committed
  5a25cb7

  Copy full SHA for 5a25cb7

• added alternative debugger for ruby > 2.0

  

  Tiago Cardoso

  committed
  b04a0db

  Copy full SHA for b04a0db

• enhanced the master branch #content_length implementation, regarding RFC compliance

  

  Tiago Cardoso

  committed
  f5b22e5

  Copy full SHA for f5b22e5

• passing content length to response body; when set, read until length is exhausted

  

  Tiago Cardoso

  committed
  ca55acf

  Copy full SHA for ca55acf

• CI has old version of bundler, and I can't set the newest platforms... shame

  

  Tiago Cardoso

  committed
  21f9d34

  Copy full SHA for 21f9d34

• tolerating the first timeout on read/write wait; like in the failing case, the socket is anyway going to be closed by the server, so allow to try a read one more time; if it's eof, all good, otherw…

  Show description for 4a39a8b
  

  Tiago Cardoso

  committed
  4a39a8b

  Copy full SHA for 4a39a8b

• added general header error, left the existing custom one for back-comp

  

  Tiago Cardoso

  committed
  f79bf10

  Copy full SHA for f79bf10

• wrong format for content length doesn't raise error, which doesn't please me, but oh well

  

  Tiago Cardoso

  committed
  f0f0231

  Copy full SHA for f0f0231

• corrected some faults coming from latest rebase

  

  Tiago Cardoso

  committed
  48c3e85

  Copy full SHA for 48c3e85

• explicit nil

  

  Tiago Cardoso

  committed
  93c9ce9

  Copy full SHA for 93c9ce9

• do not needlessly call the method, use the ivar

  

  Tiago Cardoso

  committed
  73f0816

  Copy full SHA for 73f0816

• Headers#get always returns an array, so work only with that; also, use Headers#include? to reduce allocations

  

  Tiago Cardoso

  committed
  00279ae

  Copy full SHA for 00279ae

• use Headers#include? to reduce allocations, add header conditions together

  

  Tiago Cardoso

  committed
  9a2dea1

  Copy full SHA for 9a2dea1

• according to RFC, response is only chunked only if the transfer encoding ends with chunked

  

  Tiago Cardoso

  committed
  c36d357

  Copy full SHA for c36d357

• added comment for future refactoring

  

  Tiago Cardoso

  committed
  83f3b32

  Copy full SHA for 83f3b32

• removed the extra include? call over there

  

  Tiago Cardoso

  authored and

  Tiago Cardoso

  committed
  08ec27d

  Copy full SHA for 08ec27d

• rubocoping

  

  Tiago Cardoso

  committed
  9c18fe3

  Copy full SHA for 9c18fe3

Commits on Jan 30, 2017

• rubocop <3 ...

  

  Tiago Cardoso

  committed
  6a13e2a

  Copy full SHA for 6a13e2a

Commits on Feb 3, 2017

• reintegrated kwargs in the body API, and passing the content length down

  

  Tiago Cardoso

  committed
  108e127

  Copy full SHA for 108e127

• rubo rubo rubocop

  

  Tiago Cardoso

  committed
  607e42b

  Copy full SHA for 607e42b

• rubocop, make up your mind...

  

  Tiago Cardoso

  committed
  4a90c6c

  Copy full SHA for 4a90c6c

• removing deprecation

  

  Tiago Cardoso

  committed
  21c0f60

  Copy full SHA for 21c0f60

• removed tests with deprecated error..

  

  Tiago Cardoso

  committed
  7fc577b

  Copy full SHA for 7fc577b

• rubocop again...

  

  Tiago Cardoso

  committed
  5b19215

  Copy full SHA for 5b19215

• more ruboscosps...

  

  Tiago Cardoso

  committed
  8d84978

  Copy full SHA for 8d84978

• Merge branch 'master' into issue_357

  HoneyryderChuck

  authored
  0346723

  Copy full SHA for 0346723

Commits on Feb 6, 2017

• Merge branch 'master' into issue_357

  HoneyryderChuck

  authored
  a77e80e

  Copy full SHA for a77e80e

• rbc

  

  Tiago Cardoso

  committed
  a6afeeb

  Copy full SHA for a6afeeb