Fix bug where duplicated Send tab would stop syncing headers

This meant if you duplicated a tab with a body and correct content-length field, they'd go out of sync.
httptoolkit · Nov 20, 2024 · 291715c · 291715c
1 parent 5ddef60
commit 291715c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/components/send/send-tabs.tsx b/src/components/send/send-tabs.tsx
@@ -221,7 +221,7 @@ export const SendTabs = observer((props: {
             {
                 type: 'option',
                 label: 'Duplicate Tab',
-                callback: () => props.onAddTab(_.cloneDeep(request.request))
+                callback: () => props.onAddTab(new RequestInput(request.request))
             },
             {
                 type: 'option',

diff --git a/src/model/send/send-request-model.ts b/src/model/send/send-request-model.ts
@@ -39,7 +39,7 @@ export class RequestInput {
             url: string,
             headers: RawHeaders,
             requestContentType: EditableContentType,
-            rawBody: Buffer
+            rawBody: Buffer | EditableBody
         }
     ) {
         // When deserializing, we need to ensure the body is provided directly
@@ -49,8 +49,13 @@ export class RequestInput {
             this.url = existingData.url;
             this.headers = existingData.headers;
             this.requestContentType = existingData.requestContentType;
+
+            const rawBody = existingData.rawBody instanceof EditableBody
+                ? existingData.rawBody.decoded
+                : existingData.rawBody;
+
             this.rawBody = new EditableBody(
-                existingData.rawBody,
+                rawBody,
                 undefined,
                 () => this.headers
             );