Change loggin function to have f postfix when using formated version #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change needs to go live with similar change to alyx3
It's using the newest format of logging from non-backward compatible update from
op/go-logging
package.Backwards compatibility
Since
github.com/op/go-logging
did a breaking change we decided that we'll fix the code after upgreading that package. If you use old version of go-logging con't probably won't compile, but with newest version it should all be goodOne should use Godep if is scared about that :(
Reasoning
Testing
This will affect mainly logs with formatting like
%s
. See if your logs looks ok after the change and are properly substitutedDependency consideration
After reviewing dependent hudl repos this shouldn't affect anything as those which one are using fargo uses Godep as well. For outside of hudl world if someone is using hudl/fargo and not using Godep then probably they will have a problem with op/go-logging which this PR is fixing