Correct expected status code for deregistration #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the Eureka documentation and the implementation in method com.netflix.eureka.resources.InstanceResource#cancelLease(), Eureka returns HTTP status code 200 to indicate successful deregistration of an instance, and not status code 204 as our EurekaConnection's DeregisterInstance method had expected.
damtur
approved these changes
Sep 20, 2016
|
Who is responsible for merging this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the Eureka documentation and the implementation in method
com.netflix.eureka.resources.InstanceResource#cancelLease(), Eureka returns HTTP status code 200 to indicate successful deregistration of an instance, and not status code 204 as ourEurekaConnection'sDeregisterInstancemethod had expected.This change was originally proposed as part of #47.